You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/13 00:59:22 UTC

[GitHub] [trafficserver] shinrich commented on a change in pull request #7809: Save and propagate epoll network error

shinrich commented on a change in pull request #7809:
URL: https://github.com/apache/trafficserver/pull/7809#discussion_r631494939



##########
File path: iocore/net/UnixNet.cc
##########
@@ -507,27 +507,24 @@ NetHandler::waitForActivity(ink_hrtime timeout)
       if (cop_list.in(ne)) {
         cop_list.remove(ne);
       }
-      if (get_ev_events(pd, x) & (EVENTIO_READ | EVENTIO_ERROR)) {
+      int flags = get_ev_events(pd, x);

Review comment:
       There is a ink_release_assert later in this function for that case.  I have yet to see it go off.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org