You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sam Berlin (JIRA)" <ji...@apache.org> on 2008/03/17 19:32:24 UTC
[jira] Created: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
------------------------------------------------------------------------------------------------------
Key: HTTPCLIENT-759
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpClient
Affects Versions: 4.0 Alpha 3
Reporter: Sam Berlin
See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-759.
------------------------------------------
Resolution: Fixed
Fix Version/s: 4.0 Alpha 4
Patch checked in
Many thanks, Sam
Oleg
> DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
> ------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-759
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0 Alpha 3
> Reporter: Sam Berlin
> Fix For: 4.0 Alpha 4
>
> Attachments: changes.txt
>
>
> See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579645#action_12579645 ]
Oleg Kalnichevski commented on HTTPCLIENT-759:
----------------------------------------------
Sorry. I missed that. Shall I just remove the test case for the time being and commit the patch?
Oleg
> DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
> ------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-759
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0 Alpha 3
> Reporter: Sam Berlin
> Attachments: changes.txt
>
>
> See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579660#action_12579660 ]
Sam Berlin commented on HTTPCLIENT-759:
---------------------------------------
Ya that's probably the best course for right now. I'll put some more thought into the aborting testcase & patch.
> DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
> ------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-759
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0 Alpha 3
> Reporter: Sam Berlin
> Attachments: changes.txt
>
>
> See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579611#action_12579611 ]
Oleg Kalnichevski commented on HTTPCLIENT-759:
----------------------------------------------
Good catch, Sam
Unfortunately one of the new test cases fails for me. (Ubuntu Linux 7.10; Java 1.5.0.11; single-core Intel Centrino)
Tests run: 323, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.899 sec <<< FAILURE!
testAbortInAllocate(org.apache.http.impl.client.TestDefaultClientRequestDirector) Time elapsed: 1.019 sec <<< FAILURE!
junit.framework.AssertionFailedError: should have finished get request
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at org.apache.http.impl.client.TestDefaultClientRequestDirector.testAbortInAllocate(TestDefaultClientRequestDirector.java:110)
Oleg
> DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
> ------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-759
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0 Alpha 3
> Reporter: Sam Berlin
> Attachments: changes.txt
>
>
> See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579634#action_12579634 ]
Sam Berlin commented on HTTPCLIENT-759:
---------------------------------------
Sorry -- that particular test case needs the patch from HTTPCLIENT-734. I was able to separate the patches for the non-test code, but since both tests went into the same test class (which is a new class), I had to lump them together into the patch.
> DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
> ------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-759
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0 Alpha 3
> Reporter: Sam Berlin
> Attachments: changes.txt
>
>
> See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-759) DefaultClientRequestDirector
doesn't release connections back to ClientConnectionManager on exceptions
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sam Berlin updated HTTPCLIENT-759:
----------------------------------
Attachment: changes.txt
The attached patch fixes the problem and adds two tests (that used to fail, but pass now). It's going to conflict slightly with the patch from HTTPCLIENT-734, because both are adding the new file 'TestDefaultClientRequestDirector' -- but the merge conflict is easily resolved.
(Previously the connection would only be released during the next garbage collection [which might never happen], and could prevent subsequent requests from being tried if they were waiting on an available slot.)
> DefaultClientRequestDirector doesn't release connections back to ClientConnectionManager on exceptions
> ------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-759
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-759
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.0 Alpha 3
> Reporter: Sam Berlin
> Attachments: changes.txt
>
>
> See HTTPCLIENT-747 for more info. Basically the deal is that an entry is always allocated, but currently it's only released if execute(..) completes normally.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org