You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/06 09:58:11 UTC
[GitHub] [incubator-iotdb] JulianFeinauer opened a new pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
JulianFeinauer opened a new pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158
…der.
NOTE: Should also be picked to develop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] chrisdutz commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624584259
LGTM now :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] JulianFeinauer commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624607395
+1. So I do not pick it for master, yet?
WDYT? (currently about to do that :) ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] JulianFeinauer commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624606420
Oh, sorry too late @jixuan1989. We could do separate downloads if we use multiple assembly files. Then user can decide what to download. Thats the way to go, I guess?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624606947
It is ok. I have approved it...
Maybe we can separate it in v0.10 and release more connectors at that time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624605347
LGTM.
Chris is an expert of Maven... If he says "LGTM", it really looks good for how to use Maven :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] JulianFeinauer commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624581378
@chrisdutz thanks for the hint I changed it to use the dependencySet. You can have a look if you like :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624608641
If we can not implement separating these binaries into several files quickly, I think we can pick this commit to master... to keep consistent between 0.9 and the master branch...
And then consider separating them as a new feature.
How do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1158: Add Grafana IoTDB Bridge Artefact to distrbution in tools/grafana fol…
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1158:
URL: https://github.com/apache/incubator-iotdb/pull/1158#issuecomment-624609554
Besides, when we are in the incubator, there is an issue that we can retain at most 10 files. Otherwise, there will be a warning on this page to say incubator project can have at most 10 files, please delete stale version files: http://incubator.apache.org/clutch/iotdb.html (the Release Chapter).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org