You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "innovark37 (via GitHub)" <gi...@apache.org> on 2025/12/11 15:26:49 UTC

[PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

innovark37 opened a new pull request, #36532:
URL: https://github.com/apache/superset/pull/36532

   ### SUMMARY
   This PR fixes inconsistent icon spacing in the RightMenu component. Menu items where the icon is rendered outside the label (using the icon prop) had different spacing compared to items where the icon was rendered inside the label (inline). This caused visual misalignment and inconsistent UI.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   BEFORE
   <img width="191" height="243" alt="{46BFE384-FE7D-46B3-BE59-2DBC09F7ACFE}" src="https://github.com/user-attachments/assets/1b74e42a-dbd1-45b7-a9e2-0ca61437565b" />
   
   AFTER
   <img width="194" height="242" alt="{9B387511-6C45-41A8-91A7-C05926F76509}" src="https://github.com/user-attachments/assets/e5196880-793f-4046-81cc-eda20a3738ff" />
   
   ### TESTING INSTRUCTIONS
   1. Navigate to any page with header (Welcome page, Dashboards page, Charts page, etc).
   2. Move your cursor over the `+` icon in the top-right corner. A dropdown menu (RightMenu) will appear.
   3. Verify consistent spacing between icons and labels in menu item.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36532:
URL: https://github.com/apache/superset/pull/36532#issuecomment-3642457432

   CodeAnt AI is reviewing your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36532:
URL: https://github.com/apache/superset/pull/36532#issuecomment-3696073725

   CodeAnt AI is running Incremental review
   
   ---
   
   ### Thanks for using CodeAnt! ๐ŸŽ‰
   
   We're free for open-source projects. if you're enjoying it, help us grow by sharing.
   
   [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ยท
   [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ยท
   [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36532:
URL: https://github.com/apache/superset/pull/36532#issuecomment-3657024854

   Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following:
   ```
   pip3 install -r requirements/development.txt
   pre-commit install
   ```
   A series of checks will now run when you make a git commit.
   
   Alternatively it is possible to run pre-commit by running pre-commit manually:
   ```
   pre-commit run --all-files
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36532:
URL: https://github.com/apache/superset/pull/36532#issuecomment-3686301964

   CodeAnt AI is running Incremental review
   
   ---
   
   ### Thanks for using CodeAnt! ๐ŸŽ‰
   
   We're free for open-source projects. if you're enjoying it, help us grow by sharing.
   
   [Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ยท
   [Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ยท
   [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #36532:
URL: https://github.com/apache/superset/pull/36532


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36532:
URL: https://github.com/apache/superset/pull/36532#issuecomment-3642474918

   CodeAnt AI finished reviewing your PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(RightMenu): fix inconsistent icon alignment in RightMenu items [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36532:
URL: https://github.com/apache/superset/pull/36532#issuecomment-3642472017

   ## Nitpicks ๐Ÿ”
   
   <table>
   <tr><td>๐Ÿ”’&nbsp;<strong>No security issues identified</strong></td></tr>
   <tr><td>โšก&nbsp;<strong>Recommended areas for review</strong><br><br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36532/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR389-R415'><strong>Click target changed</strong></a><br>Icons were removed from inside the Link/Typography content and instead set as the MenuItem `icon` property. That can change the clickable area and keyboard focus behavior โ€” clicking the icon might no longer activate the associated Link if the icon slot isn't inside the anchor. Verify that icons in the icon slot keep the same navigation/activation behaviour (mouse click, keyboard, screen readers) as before.<br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36532/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR379-R416'><strong>Visual/layout regression risk</strong></a><br>Moving icons from inline content into the Menu `icon` prop can affect layout rules (order, spacing) applied to `.ant-menu-item` and `.ant-menu-submenu-title`. Verify submenu headings, horizontal alignment, and responsive behavior to ensure spacing/ordering matches the intended design across breakpoints and RTL locales.<br>
   
   - [ ] <a href='https://github.com/apache/superset/pull/36532/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR392-R396'><strong>Missing test selectors</strong></a><br>Previously icons had `data-test` attributes (e.g. on the icon components). Since labels were changed to plain Link/Text nodes and icons moved, test selectors may need to be updated or new `data-test` attributes added to Link/Typography to keep automated tests stable.<br>
   
   </td></tr>
   </table>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org