You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/02 09:22:18 UTC
[GitHub] [apisix] soulbird opened a new pull request #6489: docs(style): fix json code block syntax
soulbird opened a new pull request #6489:
URL: https://github.com/apache/apisix/pull/6489
1、The tag of the json code block in markdown should be 'json' instead of 'shell'
2、Adjusting file alignment to make the document more formal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
soulbird commented on pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#issuecomment-1057571969
It contains Chinese, it seems that only. Is it possible to change '测试' to 'test'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#issuecomment-1057573622
> It contains Chinese, it seems that only. Is it possible to change '测试' to 'test'?
Yes, LTGM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6489:
URL: https://github.com/apache/apisix/pull/6489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#discussion_r817563275
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -598,7 +598,7 @@ APISIX 的 Upstream 除了基本的负载均衡算法选择外，还支持对上
**upstream 对象 json 配置内容：**
-```shell
+```json
Review comment:
we should use `shell` here.
<img width="703" alt="image" src="https://user-images.githubusercontent.com/6814606/156345849-f48ccac4-23d8-4668-aa03-de0944827bbf.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#discussion_r818237537
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -330,15 +330,15 @@ HTTP/1.1 200 OK
service 对象 json 配置内容：
-```json
+```shell
{
- "id": "1", # id
- "plugins": {}, # 指定 service 绑定的插件
- "upstream_id": "1", # upstream 对象在 etcd 中的 id ，建议使用此值
- "upstream": {}, # upstream 信息对象，不建议使用
- "name": "测试svc", # service 名称
- "desc": "hello world", # service 描述
- "enable_websocket": true, #启动 websocket 功能
+ "id": "1", # id
+ "plugins": {}, # 指定 service 绑定的插件
+ "upstream_id": "1", # upstream 对象在 etcd 中的 id ，建议使用此值
+ "upstream": {}, # upstream 信息对象，不建议使用
+ "name": "测试svc", # service 名称
Review comment:
bad indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#discussion_r817545772
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -598,7 +598,7 @@ APISIX 的 Upstream 除了基本的负载均衡算法选择外，还支持对上
**upstream 对象 json 配置内容：**
-```shell
+```json
Review comment:
Could you also update the English doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on a change in pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
soulbird commented on a change in pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#discussion_r817560807
##########
File path: docs/zh/latest/admin-api.md
##########
@@ -598,7 +598,7 @@ APISIX 的 Upstream 除了基本的负载均衡算法选择外，还支持对上
**upstream 对象 json 配置内容：**
-```shell
+```json
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang edited a comment on pull request #6489: docs(style): fix json code block syntax
Posted by GitBox <gi...@apache.org>.
leslie-tsang edited a comment on pull request #6489:
URL: https://github.com/apache/apisix/pull/6489#issuecomment-1057573622
> It contains Chinese, it seems that only. Is it possible to change '测试' to 'test'?
Yes, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org