You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "baldimir (via GitHub)" <gi...@apache.org> on 2023/12/11 14:37:00 UTC
[PR] [kie-issues#754] Use UTF-8 on important places during Quarkus build [incubator-kie-kogito-runtimes]
baldimir opened a new pull request, #3323:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3323
Fixes https://github.com/apache/incubator-kie-issues/issues/754
[TODO] There will be a Drools PR, that is requried too, here in next few minutes.
Uses UTF-8 on important places during the Quarkus build. I suggest we should do a broader encoding review during next year. There are more places, like e.g. calling String.getBytes() without encoding and similar on many places. Unfortunately this is very hard to test, as the behaviour I was fixing only happens on an environment that doesn't use UTF-8, so there are no new test cases added. If you know about some option how to add such tests, please let me know and I will add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#754] Use UTF-8 on important places during Quarkus build [incubator-kie-kogito-runtimes]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir merged PR #3323:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org