You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Mike Müller (JIRA)" <ji...@apache.org> on 2009/09/16 21:37:57 UTC
[jira] Created: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
BootstrapInstallerTest fails on Windows systems
-----------------------------------------------
Key: SLING-1113
URL: https://issues.apache.org/jira/browse/SLING-1113
Project: Sling
Issue Type: Bug
Components: Testing
Environment: Windows XP SP3
Reporter: Mike Müller
Assignee: Mike Müller
Priority: Trivial
The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756570#action_12756570 ]
Mike Müller commented on SLING-1113:
------------------------------------
If it's okay for you, I would commit the patch and close the issue.
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Müller updated SLING-1113:
-------------------------------
Attachment: BootstrapInstallerTest.java.patch
patch to fix the issue
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1113:
-------------------------------------
Attachment: SLING-1113-fmeschbe.patch
Proposed variant as explained in previous comment.
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756548#action_12756548 ]
Mike Müller commented on SLING-1113:
------------------------------------
That solves the problem. thanks.
Just one little thing: The test now covers not all possible cases. As described in [1] on a windows system the separator is "\" but if you load the file through getClass().getResource the path contains only "/" even on a windows system.
So I would like to include this case in the test cases also.
WDYT?
[1] http://markmail.org/message/3hxln3pnxdtz47ak
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756564#action_12756564 ]
Mike Müller commented on SLING-1113:
------------------------------------
Sorry haven't seen that. So the patch exactly is what we need!
thanks a lot.
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1113) BootstrapInstallerTest fails on Windows
systems
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-1113.
------------------------------------
Released.
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Fix For: Launchpad Base 2.1.0
>
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756201#action_12756201 ]
Mike Müller commented on SLING-1113:
------------------------------------
I attached a patch to solve the minor problem.
Are the any counter arguments to commit it?
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758284#action_12758284 ]
Mike Müller commented on SLING-1113:
------------------------------------
There seems to be another problem with the BootstrapInstallerTest on Windows. I will explore that first.
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Mike Müller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Müller resolved SLING-1113.
--------------------------------
Resolution: Fixed
Fix Version/s: Launchpad Base 2.0.6
Resolved in revision 817732
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Fix For: Launchpad Base 2.0.6
>
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757886#action_12757886 ]
Felix Meschberger commented on SLING-1113:
------------------------------------------
Yes, sure, just go ahead ;-)
(but just resolve don't close the issue, thanks. we will close it once we release)
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756506#action_12756506 ]
Felix Meschberger commented on SLING-1113:
------------------------------------------
How about adding tests with File.separatorChar (as in the patch you proposed)
And in BootstrapInstaller.extractFileName we first do
path = path.replace(File.separatorChar, '/');
then we can use "path.lastIndexOf('/') later
WDYT ?
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1113) BootstrapInstallerTest fails on
Windows systems
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756550#action_12756550 ]
Felix Meschberger commented on SLING-1113:
------------------------------------------
There are two tests actually:
testExtractFileNameForwardSlash is the former testExtractFileName testing forward slashes on all platforms
testExtractFileNameForwardSlashSeparatorChar tests the platform File.separatorChar
so on windows both parts are actually tested (while on linux systems the forward slash is tested twice)
> BootstrapInstallerTest fails on Windows systems
> -----------------------------------------------
>
> Key: SLING-1113
> URL: https://issues.apache.org/jira/browse/SLING-1113
> Project: Sling
> Issue Type: Bug
> Components: Testing
> Environment: Windows XP SP3
> Reporter: Mike Müller
> Assignee: Mike Müller
> Priority: Trivial
> Attachments: BootstrapInstallerTest.java.patch, SLING-1113-fmeschbe.patch
>
>
> The BootstrapInstallerTest.testExtractFileName fails because on a Windows system the separator char for a directory is \ and not /. The test does not use File.separatorChar to get the right separator but the implementation in BootstrapInstaller does.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.