You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/16 11:31:17 UTC

[GitHub] [incubator-kyuubi] zhaomin1423 commented on a change in pull request #2146: [KYUUBI #2024] Hive Backend Engine - ProcBuilder for HiveEngine

zhaomin1423 commented on a change in pull request #2146:
URL: https://github.com/apache/incubator-kyuubi/pull/2146#discussion_r827905820



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/engine/EngineType.scala
##########
@@ -23,5 +23,5 @@ package org.apache.kyuubi.engine
 object EngineType extends Enumeration {
   type EngineType = Value
 
-  val SPARK_SQL, FLINK_SQL, TRINO = Value
+  val SPARK_SQL, FLINK_SQL, TRINO, HIVE_SQL = Value

Review comment:
       So, whether to rename them anywhere or keep them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org