You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/02/02 16:52:04 UTC
[GitHub] [daffodil-vscode] arosien opened a new pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
arosien opened a new pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77
Fixes #66.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1029112160
Oh that makes why those breakpoints I added couldn't get hit make sense now.
@mbeckerle Do you have any good schemas you think could work for @arosien to unit test importing another local schema for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
Shanedell merged pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1039331750
Well, secondary schema files will often not have any global elements. But if they have complex types or group definitions those may contain local element decls that want to be breakpoints. I am assuming one can set a breakpoint on a local element decl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1033192422
@mbeckerle Am I good to merge this in since you and @tuxji both approved? I believe @arosien won't be able to.
I think the changes are good just needed to find a good schema layout to test the breakpoints in different files. But either way these changes are valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
arosien commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1035102172
> Yes you can merge this. You need a DFDL schema for testing with specifically what characteristics? Main schema is multiple files?
Correct, though there needs to be "breakpointable" schema elements in the secondary files. Often the other schema files have only type definitions, which don't seem to be "visited" during parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1029183576
So you are looking for a schema with import statements that refer to other files of the same schema?
ISO8583 is one such. github https://github.com/DFDLSchemas/ISO8583/blob/master/1993/ISO8583_1993.xsd is a file with two import statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1039331750
Well, secondary schema files will often not have any global elements. But if they have complex types or group definitions those may contain local element decls that want to be breakpoints. I am assuming one can set a breakpoint on a local element decl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
arosien commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1029090526
> @arosien So this will not allow the loading of files in the classpath correct? But does it allow for loading local schemas?
>
> What I mean is:
>
> * Say if I am testing the `pcap` daffodil schema that uses the `ethernet` schema. I should see these things right?
>
> * I add the JAR for `ethernet` to classpath but the files inside of that JAR cannot have breakpoints set or hit
Correct.
> * Ability to set break points in the `src/main/resources/com/tresys/pcap/xsd/binaryDynamicByteOrder.dfdl.xsd` and they should be hit
Correct, although I'm not sure there are any "breakpoint-able" lines in `binaryDynamicByteOrder.dfdl.xsd` because it is only type definitions. I may be wrong.
I *would* like to have an example multi-file schema to add unit tests for, let's look around for one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
Shanedell commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1028220571
@arosien So this will not allow the loading of files in the classpath correct? But does it allow for loading local schemas?
What I mean is:
- Say if I am testing the `pcap` daffodil schema that uses the `ethernet` schema. I should see these things right?
- I add the JAR for `ethernet` to classpath but the files inside of that JAR cannot have breakpoints set or hit
- Ability to set break points in the `src/main/resources/com/tresys/pcap/xsd/binaryDynamicByteOrder.dfdl.xsd` and they should be hit
Is this correct or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien edited a comment on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
arosien edited a comment on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1032778929
Hi @Shanedell, @mbeckerle, @stevedlawrence, can you take a look at this PR and give a 👍 or 👎 ?
I'm still trying to find a set of schema files that I can use to validate. The ISO8583 didn't load with a schema error. (I'll paste it in later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] arosien commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
arosien commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1032778929
Hi @Shanedell, @mbeckerle, @stevedlawrence, can you take a look at this PR and give a 👍 or 👎 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on pull request #77: Multi-file breakpoints: change Path to URI when referencing locations.
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #77:
URL: https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1033863280
Yes you can merge this.
You need a DFDL schema for testing with specifically what characteristics?
Main schema is multiple files?
On Tue, Feb 8, 2022 at 7:17 PM Shane Dell ***@***.***> wrote:
> @mbeckerle <https://github.com/mbeckerle> Am I good to merge this in
> since you and @tuxji <https://github.com/tuxji> both approved? I believe
> @arosien <https://github.com/arosien> won't be able to.
>
> I think the changes are good just needed to find a good schema layout to
> test the breakpoints in different files. But either way these changes are
> valuable.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/daffodil-vscode/pull/77#issuecomment-1033192422>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALUDA5IOK4M4PK7VK4GDSTU2GXAHANCNFSM5NMSPE5Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org