You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/11 02:52:42 UTC
[GitHub] [flink] zhengcanbin opened a new pull request #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
zhengcanbin opened a new pull request #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705
## What is the purpose of the change
Our current logic only takes care of RestOptions.PORT but not RestOptions.BIND_PORT, which is a bug; for example, when one sets the RestOptions.BIND_PORT to a value different from RestOptions.PORT, jobs could not be submitted to the existing session cluster deployed via the kubernetes-session.sh.
This PR fixes the bug.
## Brief change log
Set the RestOptions.BIND_PORT as the target port of the external Service.
## Verifying this change
This change can be tested via the existing unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11705: [FLINK-16600][k8s]
Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612724036
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160824868",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7700",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
* 75e3de010758c5e3fc562755d5d523632494df97 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160824868) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160824868",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7700",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75e3de010758c5e3fc562755d5d523632494df97 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160824868) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11705: [FLINK-16600][k8s]
Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-615885320
@TisonKun @zhengcanbin I have checked the test and changes again. If we set `rest.bind-port` explicitly, the test `testBuildAccompanyingKubernetesResources` should fail. So updating the test seems reasonable.
Now i give the pass, +1 for merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11705: [FLINK-16600][k8s] Fix
not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160824868",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7700",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75e3de010758c5e3fc562755d5d523632494df97 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160824868) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11705: [FLINK-16600][k8s]
Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-615284603
The changes looks good to me. I agree with @TisonKun that we need to add a new test, which will fails before the changes and pass after it.
For the test, i think we could have the following assumption.
* The `port` of rest service should be equal to `rest.port`.
* The `targetPort` should be equal to `rest.bind-port`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612309107
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"triggerType" : "PUSH"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159896270",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "005f7518a1843d28e9a6fb0c9c0cf3360738f4e8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351",
"triggerID" : "612724019",
"triggerType" : "MANUAL"
}, {
"hash" : "75e3de010758c5e3fc562755d5d523632494df97",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75e3de010758c5e3fc562755d5d523632494df97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159896270) Azure: [CANCELED](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7351)
* 75e3de010758c5e3fc562755d5d523632494df97 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11705: [FLINK-16600][k8s]
Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612724019
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11705: [FLINK-16600][k8s] Fix
not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612306706
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 005f7518a1843d28e9a6fb0c9c0cf3360738f4e8 (Sat Apr 11 02:56:04 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11705: [FLINK-16600][k8s]
Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-612813268
@TisonKun @tillrohrmann @wangyang0918 Could you help take a look at this PR? Thanks a lot in advance！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin edited a comment on issue #11705:
[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the
Kubernetes setup
Posted by GitBox <gi...@apache.org>.
zhengcanbin edited a comment on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-615706877
Hi, @TisonKun @wangyang0918 Thanks for your review and comments.
The test case of `ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources` already covers the test branch; before this PR, [Line 72](https://github.com/apache/flink/pull/11705/files#diff-24603b770271a33735073bf3842f07eeR72) has checked that the service port equals to the `rest.port`; after this PR, [Line 73](https://github.com/apache/flink/pull/11705/files#diff-24603b770271a33735073bf3842f07eeR73) checked that the service target port equals to the `rest.bind-port`, and if we don't add this line, `ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources` will definitely fail after this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun closed pull request #11705: [FLINK-16600][k8s] Fix
not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
TisonKun closed pull request #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11705: [FLINK-16600][k8s]
Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11705: [FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-615706877
Hi, @TisonKun @wangyang0918 Thanks for your review and comments.
The test case of `ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources` already covers the test branch; before this PR, [Line 72](https://github.com/apache/flink/pull/11705/files#diff-24603b770271a33735073bf3842f07eeR72) has checked that the service port equals to the `rest.port`; after this PR, [Line 73](https://github.com/apache/flink/pull/11705/files#diff-24603b770271a33735073bf3842f07eeR73) checked that the service target port equals to the `rest.bind-port`, and if we don't add this line, `ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources` will definitely fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services