You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/22 04:52:20 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #10388: chore: wiring ControlLabel to a new FormLabel

mistercrunch opened a new pull request #10388:
URL: https://github.com/apache/incubator-superset/pull/10388


   Creating new simple <FormLabel /> component and wiring all <label>
   and react-bootstrap.ControlLabel towards it.
   
   FormLabel becomes a pivotal point that can be altered to point to AntD
   when we're ready.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10388: chore: wiring ControlLabel to a new FormLabel

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10388:
URL: https://github.com/apache/incubator-superset/pull/10388#issuecomment-662796042


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=h1) Report
   > Merging [#10388](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3fdc141b82bb95e0f624563587c38e0fb3a6768c&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10388/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10388      +/-   ##
   ==========================================
   + Coverage   70.41%   70.45%   +0.03%     
   ==========================================
     Files         604      605       +1     
     Lines       32429    32430       +1     
     Branches     3298     3301       +3     
   ==========================================
   + Hits        22836    22848      +12     
   + Misses       9487     9476      -11     
     Partials      106      106              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.48% <80.00%> (+0.14%)` | :arrow_up: |
   | #javascript | `59.35% <81.81%> (+0.02%)` | :arrow_up: |
   | #python | `69.77% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `22.22% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS5qc3g=) | `77.77% <ø> (ø)` | |
   | [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | `8.62% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `86.20% <ø> (ø)` | |
   | [...rc/dashboard/components/FilterIndicatorTooltip.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvclRvb2x0aXAuanN4) | `100.00% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `47.94% <ø> (ø)` | |
   | [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `50.00% <ø> (ø)` | |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `81.48% <ø> (ø)` | |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `92.59% <ø> (ø)` | |
   | [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `70.00% <ø> (ø)` | |
   | ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=footer). Last update [3fdc141...8c83a0b](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #10388: chore: wiring ControlLabel to a new FormLabel

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10388:
URL: https://github.com/apache/incubator-superset/pull/10388


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10388: chore: wiring ControlLabel to a new FormLabel

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10388:
URL: https://github.com/apache/incubator-superset/pull/10388#discussion_r459237940



##########
File path: superset-frontend/src/components/FormLabel.tsx
##########
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+// import styled from '@superset-ui/style';
+import React, { ReactNode } from 'react';
+import { ControlLabel } from 'react-bootstrap';
+
+interface Props {

Review comment:
       `FormLabelProps` [would be preferred](https://github.com/apache-superset/superset-ui/pull/586).
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10388: chore: wiring ControlLabel to a new FormLabel

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10388:
URL: https://github.com/apache/incubator-superset/pull/10388#issuecomment-662796042


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=h1) Report
   > Merging [#10388](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3fdc141b82bb95e0f624563587c38e0fb3a6768c&el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `81.81%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10388/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10388      +/-   ##
   ==========================================
   - Coverage   70.41%   70.33%   -0.09%     
   ==========================================
     Files         604      605       +1     
     Lines       32429    32430       +1     
     Branches     3298     3301       +3     
   ==========================================
   - Hits        22836    22810      -26     
   - Misses       9487     9511      +24     
   - Partials      106      109       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.90% <80.00%> (-0.44%)` | :arrow_down: |
   | #javascript | `59.35% <81.81%> (+0.02%)` | :arrow_up: |
   | #python | `69.77% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `22.22% <ø> (ø)` | |
   | [...erset-frontend/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS5qc3g=) | `77.77% <ø> (ø)` | |
   | [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | `8.62% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `86.20% <ø> (ø)` | |
   | [...rc/dashboard/components/FilterIndicatorTooltip.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvclRvb2x0aXAuanN4) | `100.00% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `47.94% <ø> (ø)` | |
   | [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | `50.00% <ø> (ø)` | |
   | [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `81.48% <ø> (ø)` | |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `92.59% <ø> (ø)` | |
   | [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `70.00% <ø> (ø)` | |
   | ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/10388/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=footer). Last update [3fdc141...8c83a0b](https://codecov.io/gh/apache/incubator-superset/pull/10388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org