You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/08/17 07:45:58 UTC
[PR] Use database default schema in RefreshTableMetaDataExecutor [shardingsphere]
menghaoranss opened a new pull request, #39494:
URL: https://github.com/apache/shardingsphere/pull/39494
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database default schema in RefreshTableMetaDataExecutor [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39494:
URL: https://github.com/apache/shardingsphere/pull/39494#issuecomment-5313552546
```markdown
### Result
**Review Result: Mergeable**
The change correctly delegates default-schema resolution to `ShardingSphereDatabase` while preserving explicit-schema precedence, validation, and every refresh branch.
### Evidence
- [`RefreshTableMetaDataExecutor`](https://github.com/apache/shardingsphere/blob/8182b64bd4ab1d9e837de9c9ef9fac81aabb3bc0/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/refresh/RefreshTableMetaDataExecutor.java#L46-L90) now uses the database-owned, identifier-aware default schema.
- [`ShardingSphereDatabase.getDefaultSchemaName()`](https://github.com/apache/shardingsphere/blob/8182b64bd4ab1d9e837de9c9ef9fac81aabb3bc0/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabase.java#L303-L315) returns the actual matched schema name after protocol normalization.
- The tests retain coverage for table, schema, database, storage-unit, missing-schema, and missing-table paths.
- Focused verification passed: 13 tests, 0 failures, 0 errors.
### Coverage
- Reviewed head: `8182b64bd4ab1d9e837de9c9ef9fac81aabb3bc0`.
- All 3 authoritative [changed files](https://github.com/apache/shardingsphere/pull/39494/files) were accounted for; GitHub and local triple-dot inventories matched.
- Reviewed cluster: default-schema resolution for `REFRESH TABLE METADATA`, including handler wiring and all reload branches.
- Completed root-cause, blast-radius/contracts, tests/runtime, and final convergence passes with no blocking findings or unresolved code-evidence gaps.
- This is a code-scope result only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use database default schema in RefreshTableMetaDataExecutor [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39494:
URL: https://github.com/apache/shardingsphere/pull/39494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org