You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/07 05:17:05 UTC
[GitHub] [incubator-gobblin] abti opened a new pull request #3194: [GOBBLIN-1354] Change homepage link in documentation for mkdocs build to pass on RTD
abti opened a new pull request #3194:
URL: https://github.com/apache/incubator-gobblin/pull/3194
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1354
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Changing to apache url didnt work last time, so changing to index.md
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Not testable locally
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3194: [GOBBLIN-1354] Change homepage link in documentation for mkdocs build to pass on RTD
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3194:
URL: https://github.com/apache/incubator-gobblin/pull/3194#issuecomment-756059640
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=h1) Report
> Merging [#3194](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=desc) (d9398c4) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/1b31c907a5b46917b0d3319be49b3a88764944a2?el=desc) (1b31c90) will **increase** coverage by `37.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3194 +/- ##
=============================================
+ Coverage 9.10% 46.18% +37.07%
- Complexity 1726 9769 +8043
=============================================
Files 2017 2017
Lines 77221 77221
Branches 8568 8568
=============================================
+ Hits 7033 35662 +28629
+ Misses 69500 38249 -31251
- Partials 688 3310 +2622
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/gobblin/writer/AvroHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9BdnJvSGRmc0RhdGFXcml0ZXIuamF2YQ==) | `77.77% <0.00%> (ø)` | `5.00% <0.00%> (+1.00%)` | |
| [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `2.00% <0.00%> (+2.00%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.59% <0.00%> (+0.65%)` | `25.00% <0.00%> (+1.00%)` | |
| [...ata/management/copy/hive/HivePartitionFileSet.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlUGFydGl0aW9uRmlsZVNldC5qYXZh) | `0.93% <0.00%> (+0.93%)` | `1.00% <0.00%> (+1.00%)` | |
| [...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=) | `81.97% <0.00%> (+1.16%)` | `32.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/util/FileListUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZUxpc3RVdGlscy5qYXZh) | `71.42% <0.00%> (+1.29%)` | `28.00% <0.00%> (ø%)` | |
| [...ava/org/apache/gobblin/runtime/MultiConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXVsdGlDb252ZXJ0ZXIuamF2YQ==) | `83.60% <0.00%> (+1.63%)` | `9.00% <0.00%> (+1.00%)` | |
| [...rg/apache/gobblin/runtime/FsDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRnNEYXRhc2V0U3RhdGVTdG9yZS5qYXZh) | `73.80% <0.00%> (+1.78%)` | `35.00% <0.00%> (+1.00%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.78% <0.00%> (+2.24%)` | `35.00% <0.00%> (+3.00%)` | |
| [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `2.70% <0.00%> (+2.70%)` | `1.00% <0.00%> (+1.00%)` | |
| ... and [1061 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=footer). Last update [1b31c90...d9398c4](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3194: [GOBBLIN-1354] Change homepage link in documentation for mkdocs build to pass on RTD
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3194:
URL: https://github.com/apache/incubator-gobblin/pull/3194#issuecomment-756059640
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=h1) Report
> Merging [#3194](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=desc) (d9398c4) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/1b31c907a5b46917b0d3319be49b3a88764944a2?el=desc) (1b31c90) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3194 +/- ##
========================================
Coverage 9.10% 9.11%
- Complexity 1726 1728 +2
========================================
Files 2017 2017
Lines 77221 77221
Branches 8568 8568
========================================
+ Hits 7033 7039 +6
+ Misses 69500 69496 -4
+ Partials 688 686 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.59% <0.00%> (+0.65%)` | `25.00% <0.00%> (+1.00%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `62.50% <0.00%> (+0.96%)` | `33.00% <0.00%> (+1.00%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3194/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0.00%> (+7.14%)` | `3.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=footer). Last update [1b31c90...d9398c4](https://codecov.io/gh/apache/incubator-gobblin/pull/3194?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org