You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/24 11:17:03 UTC

Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/
-----------------------------------------------------------

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20168
    https://issues.apache.org/jira/browse/AMBARI-20168


Repository: ambari


Description
-------

Added a new function for handling firefox browser


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 5dbeb2b 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 5fa5d2e 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 70647a8 

Diff: https://reviews.apache.org/r/57033/diff/


Testing
-------

manually tested


Thanks,

Pallav Kulshreshtha


Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/#review166691
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57033/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20168
>     https://issues.apache.org/jira/browse/AMBARI-20168
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added a new function for handling firefox browser
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 5dbeb2b 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 5fa5d2e 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 70647a8 
> 
> Diff: https://reviews.apache.org/r/57033/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/#review166705
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57033/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20168
>     https://issues.apache.org/jira/browse/AMBARI-20168
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added a new function for handling firefox browser
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 5dbeb2b 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 5fa5d2e 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 70647a8 
> 
> Diff: https://reviews.apache.org/r/57033/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57033/#review166690
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On Feb. 24, 2017, 11:17 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57033/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 11:17 a.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20168
>     https://issues.apache.org/jira/browse/AMBARI-20168
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added a new function for handling firefox browser
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/log.hbs db1cea2 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs 370e3ef 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 5dbeb2b 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 5fa5d2e 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 70647a8 
> 
> Diff: https://reviews.apache.org/r/57033/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>