You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/27 13:26:18 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #55: Support qualified columns in queries

alamb commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r621203228



##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -141,7 +137,7 @@ pub enum LogicalPlan {
     /// Produces rows from a table provider by reference or from the context
     TableScan {
         /// The name of the table
-        table_name: String,
+        table_name: Option<String>,

Review comment:
       I don't fully understand how a table scan (which results in a relation) can end up without a name. What is an example of when we need to use a `None` table_name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org