You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/21 12:46:24 UTC
[GitHub] [dolphinscheduler] guoshupei opened a new issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
guoshupei opened a new issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
BG : The Process Instance have only one task
In the method of `submitPostNode`, the task successfully added to `readyToSubmitTaskQueue`, then submit task from queue, if submit failed, such as DB error, the `taskFailedSubmit` is true and `readyToSubmitTaskQueue` size is not empty.
when execute the method of `updateProcessInstanceState`,
case one: FailureStrategy is END, it return state of `FAILURE`, and update state;
case two: FailureStrategy is CONTINUE, it return state of `RUNNING_EXECUTION`, and remain the same state forever;
More seriously, both cases will cause `processInstanceExecCacheManager` not remove `WorkflowExecuteThread`
### What you expected to happen
the process instance can update the state normally and can terminate normally.
I hope it will be resolved in v2.0.6
### How to reproduce
Refer to `What happened`
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065#issuecomment-1073860919
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng removed a comment on issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
Posted by GitBox <gi...@apache.org>.
caishunfeng removed a comment on issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065#issuecomment-1078609130
> readyToSubmitTaskQueue
Good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065#issuecomment-1078609466
> I have some suggestions for modification:
>
> * Add remove operation in method of `submitStandByTask` (Figure 1)
> * Replace `processStateChangeHandler` with `stateEvents` in the method of `updateProcessInstanceState` (Figure 2), and I think this is extremely necessary.
>
> 
>
> 
Good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065#issuecomment-1078609130
> readyToSubmitTaskQueue
Good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guoshupei commented on issue #9065: [Bug] [Master] When there is only one task and the submit failed, the state of Process Instance is Incorrect
Posted by GitBox <gi...@apache.org>.
guoshupei commented on issue #9065:
URL: https://github.com/apache/dolphinscheduler/issues/9065#issuecomment-1075081245
I have some suggestions for modification:
- Add remove operation in method of `submitStandByTask` (Figure 1)
- Replace `processStateChangeHandler` with `stateEvents` in the method of `updateProcessInstanceState` (Figure 2), and I think this is extremely necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org