You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2025/11/26 10:20:46 UTC
[PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Mryange opened a new pull request, #58418:
URL: https://github.com/apache/doris/pull/58418
### What problem does this PR solve?
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3580934807
<details>
<summary>ClickBench: <b>Total hot run time: 27.52 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e8de5ac6e0af22cf86350469dfe7a289b08d332, data reload: false
query1 0.05 0.05 0.06
query2 0.10 0.05 0.05
query3 0.26 0.08 0.08
query4 1.63 0.11 0.11
query5 0.26 0.25 0.26
query6 1.16 0.66 0.64
query7 0.03 0.03 0.03
query8 0.06 0.05 0.04
query9 0.58 0.53 0.52
query10 0.58 0.57 0.58
query11 0.16 0.12 0.11
query12 0.15 0.12 0.12
query13 0.63 0.61 0.60
query14 1.00 1.00 1.01
query15 0.86 0.83 0.85
query16 0.38 0.38 0.38
query17 1.05 1.04 1.02
query18 0.22 0.23 0.19
query19 1.94 1.84 1.78
query20 0.01 0.01 0.01
query21 15.44 0.22 0.12
query22 4.88 0.07 0.05
query23 15.71 0.25 0.10
query24 2.97 0.53 0.44
query25 0.07 0.07 0.06
query26 0.15 0.15 0.14
query27 0.07 0.06 0.05
query28 4.70 1.14 0.93
query29 12.58 4.00 3.27
query30 0.28 0.14 0.12
query31 2.81 0.59 0.40
query32 3.23 0.54 0.48
query33 3.10 3.03 3.02
query34 15.78 5.11 4.54
query35 4.57 4.58 4.60
query36 0.68 0.50 0.50
query37 0.09 0.06 0.07
query38 0.07 0.04 0.03
query39 0.04 0.03 0.03
query40 0.18 0.14 0.14
query41 0.09 0.03 0.02
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.68 s
Total hot run time: 27.52 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3580917730
<details>
<summary>TPC-DS: <b>Total hot run time: 184250 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e8de5ac6e0af22cf86350469dfe7a289b08d332, data reload: false
query1 1038 413 396 396
query2 6592 1586 1561 1561
query3 6763 230 220 220
query4 25842 22996 22421 22421
query5 4391 634 473 473
query6 342 234 230 230
query7 4656 532 304 304
query8 295 257 253 253
query9 8722 2563 2569 2563
query10 536 366 310 310
query11 15521 14758 14499 14499
query12 178 114 113 113
query13 1725 583 452 452
query14 10790 8991 9021 8991
query15 216 210 193 193
query16 7418 697 548 548
query17 1270 784 654 654
query18 2037 445 349 349
query19 229 225 190 190
query20 136 127 123 123
query21 223 134 118 118
query22 3861 3887 4039 3887
query23 33104 31964 32114 31964
query24 8473 2390 2388 2388
query25 643 550 484 484
query26 1245 288 165 165
query27 2736 502 352 352
query28 4373 2161 2144 2144
query29 854 651 515 515
query30 312 243 212 212
query31 892 729 649 649
query32 86 77 76 76
query33 625 409 338 338
query34 834 898 548 548
query35 832 891 747 747
query36 915 943 853 853
query37 142 112 89 89
query38 3257 3371 3339 3339
query39 1486 1410 1433 1410
query40 229 133 118 118
query41 68 60 61 60
query42 126 118 110 110
query43 464 469 426 426
query44 1271 775 764 764
query45 193 196 175 175
query46 937 1013 649 649
query47 1716 1735 1642 1642
query48 400 428 318 318
query49 787 510 412 412
query50 686 697 412 412
query51 3952 3982 3883 3883
query52 108 112 105 105
query53 244 275 199 199
query54 313 289 279 279
query55 94 95 94 94
query56 321 333 318 318
query57 1171 1184 1085 1085
query58 293 282 269 269
query59 2404 2523 2368 2368
query60 346 349 370 349
query61 168 159 167 159
query62 788 737 656 656
query63 235 194 193 193
query64 4509 1206 920 920
query65 4065 3975 3995 3975
query66 1141 444 328 328
query67 15539 15171 14931 14931
query68 8292 972 625 625
query69 527 334 317 317
query70 1344 1260 1253 1253
query71 488 336 304 304
query72 5819 5017 4876 4876
query73 677 602 351 351
query74 8591 8729 8533 8533
query75 4057 3344 2805 2805
query76 3810 1144 732 732
query77 811 412 324 324
query78 9535 9788 8889 8889
query79 2003 800 574 574
query80 680 578 515 515
query81 493 271 239 239
query82 419 154 129 129
query83 270 273 249 249
query84 258 121 99 99
query85 914 493 455 455
query86 334 297 293 293
query87 3480 3481 3403 3403
query88 3280 2260 2250 2250
query89 393 324 293 293
query90 1964 230 223 223
query91 173 179 140 140
query92 79 78 63 63
query93 1139 984 663 663
query94 737 456 335 335
query95 508 399 385 385
query96 505 574 281 281
query97 2994 2934 2847 2847
query98 232 212 209 209
query99 1672 1419 1278 1278
Total cold run time: 272636 ms
Total hot run time: 184250 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3581276543
# BE UT Coverage Report
Increment line coverage `19.51% (8/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2e8de5ac6e0af22cf86350469dfe7a289b08d332_2e8de5ac6e0af22cf86350469dfe7a289b08d332/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2e8de5ac6e0af22cf86350469dfe7a289b08d332_2e8de5ac6e0af22cf86350469dfe7a289b08d332/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.84% (18444/34904) |
| Line Coverage | 38.35% (168603/439590) |
| Region Coverage | 33.17% (130971/394817) |
| Branch Coverage | 34.12% (56334/165098) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3584060754
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3584060799
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3580874329
<details>
<summary>TPC-H: <b>Total hot run time: 34436 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e8de5ac6e0af22cf86350469dfe7a289b08d332, data reload: false
------ Round 1 ----------------------------------
q1 17604 5107 4930 4930
q2 2051 314 208 208
q3 10256 1312 763 763
q4 10247 1003 402 402
q5 7501 2398 2346 2346
q6 186 173 136 136
q7 927 753 643 643
q8 9342 1360 1085 1085
q9 7031 5336 5342 5336
q10 6874 2210 1798 1798
q11 510 300 279 279
q12 354 371 221 221
q13 17790 3691 3103 3103
q14 235 237 222 222
q15 580 538 510 510
q16 1065 1042 952 952
q17 603 862 376 376
q18 7561 7117 7085 7085
q19 1102 971 554 554
q20 342 341 228 228
q21 3755 3299 2298 2298
q22 1085 1020 961 961
Total cold run time: 107001 ms
Total hot run time: 34436 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4969 4942 4914 4914
q2 325 398 330 330
q3 2148 2704 2253 2253
q4 1364 1790 1369 1369
q5 4263 4469 4664 4469
q6 223 181 135 135
q7 2064 1965 1833 1833
q8 2699 2624 2627 2624
q9 7507 7417 7558 7417
q10 3226 3312 2810 2810
q11 606 516 498 498
q12 732 769 637 637
q13 3509 4001 3353 3353
q14 304 348 296 296
q15 559 541 509 509
q16 1103 1136 1100 1100
q17 1185 1648 1352 1352
q18 7806 7713 7624 7624
q19 797 785 861 785
q20 2016 2079 1915 1915
q21 5037 4355 4311 4311
q22 1082 1060 1022 1022
Total cold run time: 53524 ms
Total hot run time: 51556 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3581411754
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (41/41)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58418_2e8de5ac6e0af22cf86350469dfe7a289b08d332_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58418_2e8de5ac6e0af22cf86350469dfe7a289b08d332_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.67% (24526/34223) |
| Line Coverage | 58.16% (255453/439207) |
| Region Coverage | 53.39% (213363/399631) |
| Branch Coverage | 54.77% (90914/165995) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3580625592
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #58418:
URL: https://github.com/apache/doris/pull/58418#issuecomment-3580625103
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #58418: [refine](mysql output)remove MysqlRowBuffer use in VFileResultWriter
URL: https://github.com/apache/doris/pull/58418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org