You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ma...@apache.org on 2014/01/22 23:01:54 UTC
[11/50] git commit: tweaks to docs
tweaks to docs
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/185c8826
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/185c8826
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/185c8826
Branch: refs/heads/master
Commit: 185c882606112a49c1d7359cc1de00bd273c3050
Parents: dd0d3f0
Author: Reza Zadeh <ri...@gmail.com>
Authored: Wed Jan 1 19:53:14 2014 -0800
Committer: Reza Zadeh <ri...@gmail.com>
Committed: Wed Jan 1 19:53:14 2014 -0800
----------------------------------------------------------------------
.../scala/org/apache/spark/mllib/linalg/sparsesvd.scala | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/185c8826/mllib/src/main/scala/org/apache/spark/mllib/linalg/sparsesvd.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/linalg/sparsesvd.scala b/mllib/src/main/scala/org/apache/spark/mllib/linalg/sparsesvd.scala
index 0ab05de..83b2178 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/linalg/sparsesvd.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/linalg/sparsesvd.scala
@@ -65,12 +65,10 @@ object SVD {
throw new IllegalArgumentException("Expecting a tall and skinny matrix")
}
- if (min_svalue < 1.0e-9) {
- throw new IllegalArgumentException("Minimum singular value must be greater than 1e-9")
+ if (min_svalue < 1.0e-8) {
+ throw new IllegalArgumentException("Minimum singular value requested must be greater than 1e-9")
}
- val sc = data.sparkContext
-
// Compute A^T A, assuming rows are sparse enough to fit in memory
val rows = data.map(entry =>
(entry._1._1, (entry._1._2, entry._2))).groupByKey().cache()
@@ -80,7 +78,6 @@ object SVD {
((colind1, colind2), mval1*mval2) } }
}.reduceByKey(_+_)
-
// Construct jblas A^T A locally
val ata = DoubleMatrix.zeros(n, n)
for(entry <- emits.toArray) {
@@ -97,6 +94,8 @@ object SVD {
throw new Exception("All singular values are smaller than min_svalue: " + min_svalue)
}
+ val sc = data.sparkContext
+
// prepare V for returning
val retV = sc.makeRDD(
Array.tabulate(V.rows, sigma.length){ (i,j) =>