[GitHub] [zeppelin] BagusThanatos commented on a change in pull request #4298: [ZEPPELIN-5660] Implement move gcsnotebookrepo folder

[GitBox <gi...@apache.org>]

BagusThanatos commented on a change in pull request #4298:
URL: https://github.com/apache/zeppelin/pull/4298#discussion_r814569404



##########
File path: zeppelin-plugins/notebookrepo/gcs/src/test/java/org/apache/zeppelin/notebook/repo/GCSNotebookRepoTest.java
##########
@@ -187,6 +187,28 @@ public void testRemove() throws Exception {
     assertThat(storage.get(makeBlobId(runningNote.getId(), runningNote.getPath()))).isNull();
   }
 
+  @Test
+  public void testRemoveFolder_nonexistent() throws Exception {
+    try {
+      notebookRepo.remove("id", "/name", AUTH_INFO);
+      fail();
+    } catch (IOException e) {}

Review comment:
       If I removed the try catch block, then the test would fail.
   
   The purpose of this test is to make sure that the function would throw an exception if it cannot remove the folder, resulting in the `fail()` part of the test to never be reached.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org