You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/11/20 12:14:48 UTC

[GitHub] [kibble] michalslowikowski00 opened a new issue #97: Refactor kibble.scanners.scanners.travis.scan.py

michalslowikowski00 opened a new issue #97:
URL: https://github.com/apache/kibble/issues/97


   URL checker could be split into smaller methods. It's hard to read a little bit right now.
   This could help to write tests for the URL checker.
   
   
   **Description**
   Split  `scan.py` method for smaller chunks.
   
   **Use case**
   - refactor code 
   - simplify the logic
   - add tests
   
   **Related Issues**
   N/A
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek commented on issue #97: Refactor Travis Scanner method scan.py

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #97:
URL: https://github.com/apache/kibble/issues/97#issuecomment-731144290


   We should probably introduce something like `BaseSensor` class and refactor all scanners


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on issue #97: Refactor Travis Scanner method scan.py

Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #97:
URL: https://github.com/apache/kibble/issues/97#issuecomment-734852278


   Yes, I was thinking about it. I need to check and understand how scanners work and find common patterns or smth like that. The first thing that came to my mind is the same pattern as we have in Airflow -- the base operator and base hook. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org