You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "haoch (via GitHub)" <gi...@apache.org> on 2023/07/14 23:02:37 UTC
[GitHub] [airflow] haoch opened a new pull request, #32619: Make dag_run join as lazyload by default in TaskInstance
haoch opened a new pull request, #32619:
URL: https://github.com/apache/airflow/pull/32619
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
**General problem**: `joinedload` on `TaskInstance.dag_run` is generally not needed except for UI/API (list all task instances and related fields at once), but the unnecessary `JOIN` is a killer of Airflow scheduling performance especially when there are thousands of task instances in single DagRun.
**The real problem in some large scale Airflow clusters**:
We manage thousands of airflow executors (nodes) in production, and each DagRun may have 10k task instances.
* In Scheduler side , the impact is very obvious as after making it lazy, we do see 3+ times scheduling performance improvement.
* In Executor side, when tasks are queued and preparing to execute, it will check if dependencies meet with all finished task instances, a large amount of concurrent JOIN SQL will slow database performance. Especially when the config content size of some DagRun is large, thousands of concurrent executors will pull the same large DagRun at same time and it will also a huge network throughput from database and make the whole cluster unhealthy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] haoch commented on pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "haoch (via GitHub)" <gi...@apache.org>.
haoch commented on PR #32619:
URL: https://github.com/apache/airflow/pull/32619#issuecomment-1638891474
Thanks @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #32619:
URL: https://github.com/apache/airflow/pull/32619#issuecomment-1637423034
(Housekeeping notes) As the pull request template mentions, please put the description _above_ the line, not below, to improve readability. I have modified the description for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32619:
URL: https://github.com/apache/airflow/pull/32619#issuecomment-1703331882
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #32619:
URL: https://github.com/apache/airflow/pull/32619#issuecomment-1636536293
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #32619: Make dag_run join as lazyload by default in TaskInstance
URL: https://github.com/apache/airflow/pull/32619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] haoch commented on pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "haoch (via GitHub)" <gi...@apache.org>.
haoch commented on PR #32619:
URL: https://github.com/apache/airflow/pull/32619#issuecomment-1639146511
Sure, @o-nikolas will fix all the failures firstly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #32619: Make dag_run join as lazyload by default in TaskInstance
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #32619:
URL: https://github.com/apache/airflow/pull/32619#issuecomment-1639053169
There are static code failures ([see here](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst) for how to run those locally to catch and fix them before the PR) as well as many test failures because a new unexpected arg is being passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org