You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "dbalek (via GitHub)" <gi...@apache.org> on 2023/05/23 17:06:53 UTC
[GitHub] [netbeans] dbalek opened a new pull request, #5981: VSCode: Completion for annonymous inner classes improved.
dbalek opened a new pull request, #5981:
URL: https://github.com/apache/netbeans/pull/5981
Code completion for anonymous inner class constructor should generate default implementation for all abstract methods.
E.g. code completion for:
```
Runnable r = new Runnable|
```
should generate:
```
Runnable r = new Runnable() {
@Override
public void run() {
throw new UnsupportedOperationException("Not supported yet.");
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #5981: VSCode: Completion for annonymous inner classes improved.
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek merged PR #5981:
URL: https://github.com/apache/netbeans/pull/5981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5981: VSCode: Completion for annonymous inner classes improved.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #5981:
URL: https://github.com/apache/netbeans/pull/5981#discussion_r1203423033
##########
ide/api.lsp/apichanges.xml:
##########
@@ -51,6 +51,19 @@
<!-- ACTUAL CHANGES BEGIN HERE: -->
<changes>
+ <change id="Completion_getCommand">
+ <api name="LSP_API"/>
+ <summary>Added URL to diagnostic code description</summary>
+ <version major="1" minor="17"/>
+ <date day="23" month="5" year="2023"/>
+ <author login="dbalek"/>
+ <compatibility binary="compatible" source="compatible" addition="yes" deletion="no"/>
+ <description>
+ <a href="@TOP@/org/netbeans/api/lsp/Diagnostic.html#getCommand">Completion.getCommand</a> to get an optional command
Review Comment:
Diagnostic > Completion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a diff in pull request #5981: VSCode: Completion for annonymous inner classes improved.
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek commented on code in PR #5981:
URL: https://github.com/apache/netbeans/pull/5981#discussion_r1203645061
##########
ide/api.lsp/apichanges.xml:
##########
@@ -51,6 +51,19 @@
<!-- ACTUAL CHANGES BEGIN HERE: -->
<changes>
+ <change id="Completion_getCommand">
+ <api name="LSP_API"/>
+ <summary>Added URL to diagnostic code description</summary>
+ <version major="1" minor="17"/>
+ <date day="23" month="5" year="2023"/>
+ <author login="dbalek"/>
+ <compatibility binary="compatible" source="compatible" addition="yes" deletion="no"/>
+ <description>
+ <a href="@TOP@/org/netbeans/api/lsp/Diagnostic.html#getCommand">Completion.getCommand</a> to get an optional command
Review Comment:
OOPS. Good catch. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists