You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2018/01/27 00:35:34 UTC

[GitHub] guacamole-server pull request #136: GUACAMOLE-313: Add support for logging m...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-server/pull/136

    GUACAMOLE-313: Add support for logging mouse cursor information

    This change adds low-level support for logging mouse cursor position and state within session recordings (built upon protocol-level support for doing the same), and leverages that support to include the mouse cursor within video produced by guacenc.
    
    As this requires that the session recording object track the current state of the shared mouse, the `guac_common_recording_create()` function now returns a `guac_common_recording` structure (rather than an `int`) which the caller must eventually free via `guac_common_recording_free()`.
    
    For the sake of accurate recordings, a timestamp is now included in the "mouse" instruction sent from server to client, as an acknowledgement of the server time at which the mouse had the reported state. The mouse button state is also included for completeness.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-server support-cursor-log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-server/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit b37e73488f460ec20f147a2584a50b2f07e74729
Author: Michael Jumper <mj...@...>
Date:   2017-11-27T17:38:20Z

    GUACAMOLE-313: Provide reference to in-progress screen recording.

commit df770ae4ea09505d3eb72181b9dff9169926f0bb
Author: Michael Jumper <mj...@...>
Date:   2017-11-27T21:03:21Z

    GUACAMOLE-313: Add support for including mouse location within session recordings.

commit a14832c4daa933bdfd32df8985b223a77b381aa1
Author: Michael Jumper <mj...@...>
Date:   2017-11-27T22:21:06Z

    GUACAMOLE-313: Implement the "cursor" instruction to guacenc.

commit cafcd90f9fd794d767a0883939436f5487d39a77
Author: Michael Jumper <mj...@...>
Date:   2017-11-27T22:24:58Z

    GUACAMOLE-313: Add support for the "mouse" instruction to guacenc.

commit e2455d6f26513c2d1e9bf7304c8b15436b58b9ef
Author: Michael Jumper <mj...@...>
Date:   2017-11-28T03:32:59Z

    GUACAMOLE-313: Do not render cursor unless mouse has actually moved.

commit a74d6a2aaf40bcf997086b846c7b5904682852e7
Author: Michael Jumper <mj...@...>
Date:   2017-11-28T04:08:34Z

    GUACAMOLE-313: Include timestamp with mouse position reporting.

commit 7eb4e22515c2e3255e661bf26e27631940d5e231
Author: Michael Jumper <mj...@...>
Date:   2017-11-28T04:18:20Z

    GUACAMOLE-313: Use mouse timestamps for frames as well as sync.

commit 81a0e66d9f3dbd245adc8f4692ffa9e3175463f7
Author: Michael Jumper <mj...@...>
Date:   2017-12-08T18:45:09Z

    GUACAMOLE-313: Include current button state within mouse update for completeness.

----


---

[GitHub] guacamole-server pull request #136: GUACAMOLE-313: Add support for logging m...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-server/pull/136


---