[jira] [Commented] (CALCITE-5419) Verify that null values are handled properly by spatial type functions

["Bertil Chapuis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643069#comment-17643069 ] 

Bertil Chapuis commented on CALCITE-5419:
-----------------------------------------

After reading a the javadoc for [SqlFunctions|https://javadoc.io/doc/org.apache.calcite/calcite-core/1.26.0/org/apache/calcite/runtime/SqlFunctions.html], it looks like checks for nulls are performed by Calcite before calling the functions. From what I understand, the default behavior is as follow: the functions always return null if one or more of its arguments are null. This behavior looks similar to what postgis does.

Originally, most functions in SpatialTypeFunctions had a @Nullable before their return type. Would it make sense to use @Strict and @SemiStrict instead?

> Verify that null values are handled properly by spatial type functions
> ----------------------------------------------------------------------
>
>                 Key: CALCITE-5419
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5419
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Bertil Chapuis
>            Assignee: Bertil Chapuis
>            Priority: Major
>
> We should verify that null values are handled properly in the spatial type functions. We should add test cases to spatial.iq to ensure that this is the case.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)