You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/09/18 10:28:51 UTC
[PR] Enable maven check server dependencies [celeborn]
cxzl25 opened a new pull request, #2742:
URL: https://github.com/apache/celeborn/pull/2742
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable maven check server dependencies [celeborn]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #2742:
URL: https://github.com/apache/celeborn/pull/2742#discussion_r1766239717
##########
dev/dependencies.sh:
##########
@@ -208,7 +206,7 @@ case "$MODULE" in
;;
*)
MODULE="server"
- MVN_MODULES="worker,master"
+ MVN_MODULES="worker,master,cli"
Review Comment:
The cli project introduces picocli dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1600] Enable check server dependencies [celeborn]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #2742:
URL: https://github.com/apache/celeborn/pull/2742#issuecomment-2360623806
@pan3793 @cfmcgrady @waitinfuture @turboFei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable maven check server dependencies [celeborn]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #2742:
URL: https://github.com/apache/celeborn/pull/2742#discussion_r1766236167
##########
project/CelebornBuild.scala:
##########
@@ -185,7 +188,7 @@ object Dependencies {
val httpClient5 = "org.apache.httpcomponents.client5" % "httpclient5" % httpClient5Version
val httpCore5 = "org.apache.httpcomponents.core5" % "httpcore5" % httpCore5Version
val httpCore5H2 = "org.apache.httpcomponents.core5" % "httpcore5-h2" % httpCore5Version
- val javaxAnnotationApi = "javax.annotation" % "javax.annotation-api" % javaxAnnotationApiVersion
+ val jakartaAnnotationApi = "jakarta.annotation" % "jakarta.annotation-api" % jakartaAnnotationApiVersion
Review Comment:
Introduced by CELEBORN-1477, the dependencies of SBT and maven are different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1600] Enable check server dependencies [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2742: [CELEBORN-1600] Enable check server dependencies
URL: https://github.com/apache/celeborn/pull/2742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable maven check server dependencies [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2742:
URL: https://github.com/apache/celeborn/pull/2742#issuecomment-2360104342
Thanks, it would be helpful to connect this PR to a Jira ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1600] Enable check server dependencies [celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #2742:
URL: https://github.com/apache/celeborn/pull/2742#discussion_r1767012261
##########
dev/dependencies.sh:
##########
@@ -56,13 +56,29 @@ function mvn_build_classpath() {
}
function sbt_build_client_classpath() {
- PATTERN="$SBT_PROJECT / Runtime / managedClasspath"
- deps=$(
- $SBT -P$MODULE "clean; export Runtime/managedClasspath" | \
- awk -v pat="$PATTERN" '$0 ~ pat { found=1 } found { print }' | \
- awk 'NR==2' | \
- tr ":" "\n"
- )
+ PATTERN="$SBT_PROJECT / Runtime / managedClasspath"
Review Comment:
indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable maven check server dependencies [celeborn]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #2742:
URL: https://github.com/apache/celeborn/pull/2742#discussion_r1766239077
##########
dev/deps/dependencies-client-mr:
##########
@@ -72,13 +72,13 @@ jackson-annotations/2.15.3//jackson-annotations-2.15.3.jar
jackson-core-asl/1.9.13//jackson-core-asl-1.9.13.jar
jackson-core/2.15.3//jackson-core-2.15.3.jar
jackson-databind/2.15.3//jackson-databind-2.15.3.jar
-jackson-jaxrs-base/2.12.7//jackson-jaxrs-base-2.12.7.jar
-jackson-jaxrs-json-provider/2.12.7//jackson-jaxrs-json-provider-2.12.7.jar
+jackson-jaxrs-base/2.15.3//jackson-jaxrs-base-2.15.3.jar
Review Comment:
### main
`jackson-jaxrs-base-2.13.2.jar` `jackson-jaxrs-base-2.15.3.jar`
```
ls -al | grep jackson
-rw-r--r--@ 1 csy wheel 75565 9 18 18:33 jackson-annotations-2.15.3.jar
-rw-r--r--@ 1 csy wheel 549233 9 18 18:33 jackson-core-2.15.3.jar
-rw-r--r--@ 1 csy wheel 1620120 9 18 18:33 jackson-databind-2.15.3.jar
-rw-r--r--@ 1 csy wheel 19662 9 18 18:33 jackson-databind-nullable-0.2.6.jar
-rw-r--r--@ 1 csy wheel 54629 9 18 18:33 jackson-dataformat-yaml-2.15.3.jar
-rw-r--r--@ 1 csy wheel 122937 9 18 18:33 jackson-datatype-jsr310-2.15.3.jar
-rw-r--r--@ 1 csy wheel 31149 9 18 18:33 jackson-jaxrs-base-2.13.2.jar
-rw-r--r--@ 1 csy wheel 31857 9 18 18:33 jackson-jaxrs-base-2.15.3.jar
-rw-r--r--@ 1 csy wheel 15964 9 18 18:33 jackson-jaxrs-json-provider-2.13.2.jar
-rw-r--r--@ 1 csy wheel 16636 9 18 18:33 jackson-jaxrs-json-provider-2.15.3.jar
-rw-r--r--@ 1 csy wheel 36826 9 18 18:33 jackson-module-jaxb-annotations-2.14.1.jar
-rw-r--r--@ 1 csy wheel 36668 9 18 18:33 jackson-module-jaxb-annotations-2.15.3.jar
-rw-r--r--@ 1 csy wheel 513956 9 18 18:33 jackson-module-scala_2.12-2.15.3.jar
-rw-r--r--@ 1 csy wheel 76924 9 18 18:33 jersey-media-json-jackson-2.39.1.jar
```
### PR
```
-rw-r--r--@ 1 csy wheel 75565 9 18 18:54 jackson-annotations-2.15.3.jar
-rw-r--r--@ 1 csy wheel 549233 9 18 18:54 jackson-core-2.15.3.jar
-rw-r--r--@ 1 csy wheel 1620120 9 18 18:54 jackson-databind-2.15.3.jar
-rw-r--r--@ 1 csy wheel 19662 9 18 18:54 jackson-databind-nullable-0.2.6.jar
-rw-r--r--@ 1 csy wheel 54629 9 18 18:54 jackson-dataformat-yaml-2.15.3.jar
-rw-r--r--@ 1 csy wheel 122937 9 18 18:54 jackson-datatype-jsr310-2.15.3.jar
-rw-r--r--@ 1 csy wheel 31857 9 18 18:54 jackson-jaxrs-base-2.15.3.jar
-rw-r--r--@ 1 csy wheel 16636 9 18 18:54 jackson-jaxrs-json-provider-2.15.3.jar
-rw-r--r--@ 1 csy wheel 36668 9 18 18:54 jackson-module-jaxb-annotations-2.15.3.jar
-rw-r--r--@ 1 csy wheel 513956 9 18 18:54 jackson-module-scala_2.12-2.15.3.jar
-rw-r--r--@ 1 csy wheel 76924 9 18 18:54 jersey-media-json-jackson-2.39.1.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org