You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by et...@apache.org on 2008/03/02 00:43:57 UTC

svn commit: r632675 - in /incubator/shindig/trunk/features: core/config.js rpc/rpc.js

Author: etnu
Date: Sat Mar  1 15:43:46 2008
New Revision: 632675

URL: http://svn.apache.org/viewvc?rev=632675&view=rev
Log:
Applying patch for SHINDIG-101 as well as dropping support for st as an rpc validation parameter (in practice, it's usually far too large to be suitable for this task, and we need to be using simple integers instead).

Modified:
    incubator/shindig/trunk/features/core/config.js
    incubator/shindig/trunk/features/rpc/rpc.js

Modified: incubator/shindig/trunk/features/core/config.js
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/core/config.js?rev=632675&r1=632674&r2=632675&view=diff
==============================================================================
--- incubator/shindig/trunk/features/core/config.js (original)
+++ incubator/shindig/trunk/features/core/config.js Sat Mar  1 15:43:46 2008
@@ -194,7 +194,7 @@
     },
 
     /**
-     * Similar to the ECMAScript4 virtual typing system, ensures that
+     * Similar to the ECMAScript 4 virtual typing system, ensures that
      * whatever object was passed in is "like" the existing object.
      * Doesn't actually do type validation though, but instead relies
      * on other validators.
@@ -212,7 +212,7 @@
      */
     LikeValidator : function(test) {
       return function(data) {
-        for (var member in test) {
+        for (var member in test) if (test.hasOwnProperty(member)) {
           var t = test[member];
           if (!t(data[member])) {
             return false;

Modified: incubator/shindig/trunk/features/rpc/rpc.js
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/features/rpc/rpc.js?rev=632675&r1=632674&r2=632675&view=diff
==============================================================================
--- incubator/shindig/trunk/features/rpc/rpc.js (original)
+++ incubator/shindig/trunk/features/rpc/rpc.js Sat Mar  1 15:43:46 2008
@@ -39,7 +39,7 @@
 
   var params = gadgets.util.getUrlParameters();
   var parentUrl = params.parent || '';
-  authToken['..'] = params.rpctoken || params.ifpctok || params.st;
+  authToken['..'] = params.rpctoken || params.ifpctok || 0;
 
   // Pick the most efficient RPC relay mechanism
   var relayChannel = typeof document.postMessage === 'function' ? 'dpm' :