You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "laurentgo (via GitHub)" <gi...@apache.org> on 2024/04/02 15:35:37 UTC
[PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
laurentgo opened a new pull request, #40953:
URL: https://github.com/apache/arrow/pull/40953
### Rationale for this change
Module `flight-sql-jdbc-driver` declares multiple dependencies, some (joda and bytebuddy) are not used anymore (but still packaged).
### What changes are included in this PR?
Clean up list of dependencies declared in flight-sql-jdbc-driver modules as all of them are transitive dependencies from flight-sql-jdbc-core.
### Are these changes tested?
Yes: build + existing shading test
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2032399993
:warning: GitHub issue #40952 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033222893
Ah, sorry.
@assignUser or @raulcd do we need to switch to `docker compose` instead of `docker-compose` for our actions now? https://github.com/actions/runner-images/issues/9557 and the failing build is on a newer runner image than the passing builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033219148
> Install docker/docker-compose, for archery
The issue is actually for the `Java/AMD64 JDK8 Ubuntu` check
> Do we need to shade in -core? I had thought the point of having the split was not to shade
I have no idea to be honest, I see a lot of shading in `flight-sql-jdbc-core` and `vector` but not sure if those shaded artifacts are actually used or not, and for what purpose. I would argue that `maven-shade-modules` should only be used in leaf modules as having dependencies between modules in the same reactor may cause weird behavior (the main one being that the classes and pom.xml being may change based on the maven invocation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033149591
Install docker/docker-compose, for archery
Do we need to shade in -core? I had thought the point of having the split was _not_ to shade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2032508620
I thought `bytebuddy` was declared but not used, but it seems I got fooled by running `dependency:tree` and forgot that `flight-sql-jdbc-core` uses shading too and has a reduced pom.xml generated which causes issues when executing modules independently. Will address shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #40953:
URL: https://github.com/apache/arrow/pull/40953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2034830370
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 41a989c81616aea103e554521fa6d6209ffa248d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23398563086) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033266222
Yes that's right, Antoine is working on it here: https://github.com/apache/arrow/pull/40949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033272745
@github-actions crossbow submit *java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "laurentgo (via GitHub)" <gi...@apache.org>.
laurentgo commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2032524679
I'm noticing some build issues with archery:
```
Run archery docker run \
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.18/x64/bin/archery", line 8, in <module>
sys.exit(archery())
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/core.py", line 1685, in invoke
super().invoke(ctx)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/click/decorators.py", line 33, in new_func
return f(get_current_context(), *args, **kwargs)
File "/home/runner/work/arrow/arrow/dev/archery/archery/docker/cli.py", line 67, in docker
compose = DockerCompose(config_path, params=os.environ,
File "/home/runner/work/arrow/arrow/dev/archery/archery/docker/core.py", line 169, in __init__
self.config = ComposeConfig(config_path, dotenv_path, compose_bin,
File "/home/runner/work/arrow/arrow/dev/archery/archery/docker/core.py", line 68, in __init__
self._read_config(config_path, compose_bin)
File "/home/runner/work/arrow/arrow/dev/archery/archery/docker/core.py", line 127, in _read_config
result = compose.run(*args, env=self.env, check=False,
File "/home/runner/work/arrow/arrow/dev/archery/archery/utils/command.py", line 78, in run
return subprocess.run(invocation, **kwargs)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py", line 493, in run
with Popen(*popenargs, **kwargs) as process:
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py", line 858, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/subprocess.py", line 1720, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'docker-compose'
Error: Process completed with exit code 1.
```
Is there anything I can do to address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033274472
Revision: 06b92a76f200ee84bec03017aa9a7da8ccef3701
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1169653e46](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1169653e46)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/8530777975/job/23369190003)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8530777898/job/23369189141)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8530777903/job/23369189114)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8530777971/job/23369189428)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8530777908/job/23369189106)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8530777932/job/23369189117)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40952: [Java][FlightSQL] Clean up flight-sql-jdbc-driver dependencies [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #40953:
URL: https://github.com/apache/arrow/pull/40953#issuecomment-2033272467
> Yes that's right, Antoine is working on it here: #40949
Ah whoops. We can ignore the failure here then. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org