You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Peter <ji...@zeus.net.au> on 2015/11/27 23:46:38 UTC

Re: svn commit: r1716613

Last attempt at sending this to the list:

During stress testing, the jeri multiplexer can fail when the jvm runs 
out of memory and cannot create new Threads.  The mux lock can also 
become a point of thread contention.  The changes avoid creating new 
objects, using a bitset and array  (that doesn't allocate new objects) 
instead of collection classes.

The code changes also reduce the time a monitor is held, thus reducing 
contention under load.

Peter.

>
> In order to properly review changes, it would be great to know what the problem it is that you’re fixing - could you share? 
>
>
> Cheers,
>
> Greg Trasuk
>


Re: svn commit: r1716613

Posted by Gregg Wonderly <gr...@wonderly.org>.
These kinds of contention reductions can be a huge gain for overall performance.

The fastest time through is never faster than the time through the highest contended spot!

Gregg

Sent from my iPhone

> On Nov 27, 2015, at 4:46 PM, Peter <ji...@zeus.net.au> wrote:
> 
> Last attempt at sending this to the list:
> 
> During stress testing, the jeri multiplexer can fail when the jvm runs out of memory and cannot create new Threads.  The mux lock can also become a point of thread contention.  The changes avoid creating new objects, using a bitset and array  (that doesn't allocate new objects) instead of collection classes.
> 
> The code changes also reduce the time a monitor is held, thus reducing contention under load.
> 
> Peter.
> 
>> 
>> In order to properly review changes, it would be great to know what the problem it is that you’re fixing - could you share? 
>> 
>> Cheers,
>> 
>> Greg Trasuk
>