You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@infra.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/07/13 22:50:35 UTC
[jira] [Created] (INFRA-5046) Apache Giraph reviewboard not working
correctly
Avery Ching created INFRA-5046:
----------------------------------
Summary: Apache Giraph reviewboard not working correctly
Key: INFRA-5046
URL: https://issues.apache.org/jira/browse/INFRA-5046
Project: Infrastructure
Issue Type: Task
Security Level: public (Regular issues)
Reporter: Avery Ching
Apache Giraph used to be in the incubator until 5/2012.
For reviewboard
base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
used to work with submitting reviews. Now, after the move, we try to use
base directory: http://svn.apache.org/repos/asf/giraph/trunk
and it will fail on the first file in the diff, although the file exists:
i.e.
The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
We can see that the file actually exists
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
and that the revision exists as well.
http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428461#comment-13428461 ]
Gavin commented on INFRA-5046:
------------------------------
Giraph repo is configured as http://svn.apache.org/repos/asf/giraph - to allow for patch to branches etc. BasePath should therefore be '/trunk' or 'trunk'
'
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414113#comment-13414113 ]
Avery Ching commented on INFRA-5046:
------------------------------------
Thanks so much Gavin! It works for me.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428473#comment-13428473 ]
Gavin commented on INFRA-5046:
------------------------------
No problem, one follow up question.
I just got this error a few times in our logs:
"...DiffParserError: No valid separator after the filename was found in the diff header..."
Normally I'd put that down to someone applying an svn diff to a git repo or vice-versa - did anything like that happen for you just now or did you get a different error, no error or ?
Thanks.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414996#comment-13414996 ]
Alessandro Presta commented on INFRA-5046:
------------------------------------------
I'm trying to use post-review instead of uploading the diff manually.
Now I get this error:
==> HTTP Authentication Required
Enter authorization information for "Web API" at reviews.apache.org
Username: apresta
Password:
Error creating review request: You are not logged in (HTTP 401, API Error 103)
I'm using svn 1.7.5 and I ran "svn propset reviewboard:url http://reviews.apache.org ." in my project root.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415067#comment-13415067 ]
Alessandro Presta commented on INFRA-5046:
------------------------------------------
This is how I solved it for now: I created the patch from IntelliJ IDEA, then I edited it and, for all new files, replaced "(revision )" with "(revision 0)" in lines starting with "---".
The patch created by svn on the command line doesn't have this problem, but it has a problem with renamed files.
I'll check svn options to see if this can be avoided.
As for post-review, I'm still stuck at the login phase, so for now I'm using Review Board manually.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415728#comment-13415728 ]
Avery Ching commented on INFRA-5046:
------------------------------------
Gavin, once more question. Reviewboard used to automatically post to the JIRA, did something change here? It doesn't appear to happen anymore.
https://issues.apache.org/jira/browse/GIRAPH-224
https://reviews.apache.org/r/5986/
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415500#comment-13415500 ]
Avery Ching commented on INFRA-5046:
------------------------------------
I am using git-svn and did
git config reviewboard.url https://reviews.apache.org
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415983#comment-13415983 ]
#asfinfra IRC Bot commented on INFRA-5046:
------------------------------------------
<pctony> RB now posts to dev@giraph
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433975#comment-13433975 ]
Avery Ching commented on INFRA-5046:
------------------------------------
Gavin, thanks again for all your help! There are still a few issues with reviewboard that we could really use your help on. Please let us know if you are not the right person to contact.
1) Reviewboard used to automatically post to the relevant JIRA based on the "Bugs: entry". For instance, https://reviews.apache.org/r/6600/ should have posted to https://issues.apache.org/jira/browse/GIRAPH-300. This no longer happens.
2) I am still getting moderate reviews for every reviewboard posting. Have you seen this for other projects? It seemed to also have occurred after the move out of the incubator. Would really appreciate your help with this one as well.
Here is an example below:
Subject:
MODERATE for dev@giraph.apache.org
From:
dev-reject-1344929528.87753.oellomidngbomiepblpl@giraph.apache.org
Date:
8/14/12 12:32 AM
To:
Recipient list not shown: ;
CC:
dev-allow-tc.1344929528.hlcimadaieekbgjlgmpo-noreply=reviews.apache.org@giraph.apache.org
To approve:
dev-accept-1344929528.87753.oellomidngbomiepblpl@giraph.apache.org
To reject:
dev-reject-1344929528.87753.oellomidngbomiepblpl@giraph.apache.org
To give a reason to reject:
%%% Start comment
%%% End comment
ForwardedMessage.eml
Subject:
Review Request: GIRAPH-300 : Improve netty reliability with retrying failed connections, tracking requests, thread-safe hash partitioning
From:
"Avery Ching" <av...@gmail.com>
Date:
8/14/12 12:32 AM
To:
"Avery Ching" <av...@gmail.com>, "giraph" <de...@giraph.apache.org>
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6600/
Review request for giraph.
By Avery Ching.
Description
* Upgrade to the most recent stable version of Netty (3.5.3.Final)
* Try multiple connection attempts up to n failures
* Track requests throughout the system by keeping track of the request id and then matching the request id to the response (minor refactoring of WritableRequest to make requests simpler and support the request id)
* Improved handling of netty exceptions by dumping the exception stack to help debug failures
* Fixes bug in HashWorkerPartitioner by making partitionList thread-safe (this causes divide by zero exceptions in real life)
Testing
Currently, netty connection failures causes issues with more than 75 workers in my setup. This allows us to reach over 200+ in a reasonably reliable network that doesn't kill connections.
This code passes the local Hadoop regressions and the single node Hadoop instance regressions. It also succeeded on large runs (200+ workers) on a real Hadoop cluster.
Bugs: GIRAPH-300
Diffs
http://svn.apache.org/repos/asf/giraph/trunk/pom.xml (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyClient.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyServer.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyWorkerClient.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/RequestInfo.java (PRE-CREATION)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/RequestServerHandler.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/ResponseClientHandler.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMutationsRequest.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendVertexRequest.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/WritableRequest.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/utils/TimedLogger.java (1372575)
http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java (1372575)
View Diff
Attachments:
ForwardedMessage.eml 10.3 KB
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415041#comment-13415041 ]
Gavin commented on INFRA-5046:
------------------------------
try https ?
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415457#comment-13415457 ]
Avery Ching commented on INFRA-5046:
------------------------------------
Alessandro, try 'post-review -n > ~/diff.txt' and see if that works to generate a file that can be uploaded to reviewboard.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching reopened INFRA-5046:
--------------------------------
Reopening to answer a question about reviewboard posting to the JIRA
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415484#comment-13415484 ]
Alessandro Presta commented on INFRA-5046:
------------------------------------------
Avery, this one seems to cope well with new/renamed files, but all paths in the diff start with "giraph/trunk/src" instead of just "src".
How did you configure post-review? If I add the REPOSITORY option to .reviewboardrc, it doesn't let me run post-review without specifying a revision range or a diff file.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414164#comment-13414164 ]
Alessandro Presta commented on INFRA-5046:
------------------------------------------
I'm now getting a different kind of error:
"A server error occurred"
Error Code: 0
Error Text: n/a
Request URL: https://reviews.apache.org/api/review-requests/5946/diffs/
Request Data: (none)
Patch generated with SVN 1.7; base directory: http://svn.apache.org/repos/asf/giraph/trunk
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (INFRA-5046) Apache Giraph reviewboard not working
correctly
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
#asfinfra IRC Bot closed INFRA-5046.
------------------------------------
Resolution: Fixed
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415987#comment-13415987 ]
Avery Ching commented on INFRA-5046:
------------------------------------
Thanks pctony! Will reviewboard changes post to the JIRA directly now?
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415993#comment-13415993 ]
#asfinfra IRC Bot commented on INFRA-5046:
------------------------------------------
<pctony> One way to find out.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415056#comment-13415056 ]
Alessandro Presta commented on INFRA-5046:
------------------------------------------
I recompiled svn with neon (to make sure it can handle http) and re-ran propset with https.
Still get the same API error.
Also tried creating the review manually by uploading the diff, using https in the base directory. No luck.
I think I have two different issues here: one is the diff format (for some reason, Review Board doesn't like my diffs when they include new files); the other one is API login via post-review.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428471#comment-13428471 ]
Jakob Homan commented on INFRA-5046:
------------------------------------
that worked. I thought I had tried that one... I've updated our wiki for the future. Thanks.
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (INFRA-5046) Apache Giraph reviewboard not working
correctly
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gavin closed INFRA-5046.
------------------------
Resolution: Fixed
All we needed to know was "we moved to TLP, please update reviewboard"
Perhaps someone will update the Incubator TLP move docs to mention this is something that needs to be requested as part of the move. (Reviewboard repos are hard coded and need manual changes)
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415904#comment-13415904 ]
Avery Ching commented on INFRA-5046:
------------------------------------
Gavin, one more issue. I think that reviewboard for Apache Giraph is sending messages to "giraph" <gi...@incubator.apache.org> instead of "giraph" <de...@giraph.apache.org>. Can you please take a look at this as well? Or help direct me how to fix it? Thanks!!!
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not
working correctly
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428361#comment-13428361 ]
Jakob Homan commented on INFRA-5046:
------------------------------------
What's the proper basepath for review board? http://svn.apache.org/repos/asf/giraph/trunk isn't work for me. Should I file a new JIRA?
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
> Key: INFRA-5046
> URL: https://issues.apache.org/jira/browse/INFRA-5046
> Project: Infrastructure
> Issue Type: Task
> Security Level: public(Regular issues)
> Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard
> base directory: http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews. Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e.
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java' (r1356104) could not be found in the repository
> We can see that the file actually exists
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us? After the move to TLP, we havn't been able to submit reviews. Thanks!!!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira