You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mi...@apache.org on 2024/01/08 19:06:38 UTC

(impala) 03/04: IMPALA-11909: Use absolute path when calling resolve_minidumps.py

This is an automated email from the ASF dual-hosted git repository.

michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit fdd928563f2f5be05828bfeed24516449bb8f30b
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Wed Feb 15 16:36:56 2023 -0800

    IMPALA-11909: Use absolute path when calling resolve_minidumps.py
    
    If the bin/jenkins/finalize.sh script is called from a directory
    other than $IMPALA_HOME, it's call to resolve_minidumps.py will
    fail due to the relative path. This changes the call to use
    the absolute path so that finalize.sh works in this case.
    
    Testing:
     - Ran bin/jenkins/finalize.sh from a directory other than
       $IMPALA_HOME
    
    Change-Id: I063843554b52d3e8ed79ee32d9fd4c90d059c482
    Reviewed-on: http://gerrit.cloudera.org:8080/20801
    Reviewed-by: Michael Smith <mi...@cloudera.com>
    Tested-by: Joe McDonnell <jo...@cloudera.com>
---
 bin/jenkins/finalize.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/jenkins/finalize.sh b/bin/jenkins/finalize.sh
index 2057b7306..2c8db754d 100755
--- a/bin/jenkins/finalize.sh
+++ b/bin/jenkins/finalize.sh
@@ -67,7 +67,7 @@ if [[ $(find $LOGS_DIR -path "*minidumps*" -name "*dmp") ]]; then
   for minidump in $(find $LOGS_DIR -path "*minidumps*" -name "*dmp"); do
     # Since this is experimental, use it inside an if so that any error code doesn't
     # abort this script.
-    if ! bin/resolve_minidumps.py --minidump_file ${minidump} \
+    if ! "${IMPALA_HOME}"/bin/resolve_minidumps.py --minidump_file ${minidump} \
         --output_file ${minidump}_dumpedv2 ; then
       echo "bin/resolve_minidumps.py failed!"
     else