[jira] [Created] (DRILL-5161) Several TestConvertFunctions tests produce scalar replacement errors

["Paul Rogers (JIRA)" <ji...@apache.org>]

Paul Rogers created DRILL-5161:
----------------------------------

             Summary: Several TestConvertFunctions tests produce scalar replacement errors
                 Key: DRILL-5161
                 URL: https://issues.apache.org/jira/browse/DRILL-5161
             Project: Apache Drill
          Issue Type: Bug
    Affects Versions: 1.8.0
            Reporter: Paul Rogers
            Priority: Minor


Run the unit test {{TestConvertFunctions}}. The {{testBinaryString}} test emits an ASM error (see below), though the test succeeds. In addition, the test {{testConvertFromConvertToInt}} also emits the error if the line to turn off scalar replacement is commented out (see test.)

Another bug complains about the stack trace displayed when scalar replacement fails.

This bug says that we should either not use scalar replacement if we can predict it will fail, or disable scalar replacement altogether so that we get clean tests. (Work elsewhere suggested that the Java compiler and runtime already to scalar replacement for us in the latest Java versions.)

Stack trace:

{code}
unning org.apache.drill.exec.physical.impl.TestConvertFunctions#testBinaryString
org.objectweb.asm.tree.analysis.AnalyzerException: Error at instruction 175: Expected an object reference, but found .
	at org.objectweb.asm.tree.analysis.Analyzer.analyze(Analyzer.java:294)
	at org.objectweb.asm.util.CheckMethodAdapter$1.visitEnd(CheckMethodAdapter.java:450)
	at org.objectweb.asm.MethodVisitor.visitEnd(MethodVisitor.java:877)
...
	at org.objectweb.asm.tree.ClassNode.accept(ClassNode.java:412)
	at org.apache.drill.exec.compile.MergeAdapter.getMergedClass(MergeAdapter.java:227)
	at org.apache.drill.exec.compile.ClassTransformer.getImplementationClass(ClassTransformer.java:280)
	at org.apache.drill.exec.compile.ClassTransformer.getImplementationClass(ClassTransformer.java:226)
	at org.apache.drill.exec.compile.CodeCompiler$Loader.load(CodeCompiler.java:128)
	at org.apache.drill.exec.compile.CodeCompiler$Loader.load(CodeCompiler.java:1)
...
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)