You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/29 21:04:53 UTC

[GitHub] [flink] ayushtkn commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().

ayushtkn commented on issue #10966: FLINK-15740. Remove Deadline#timeLeft().
URL: https://github.com/apache/flink/pull/10966#issuecomment-579958721
 
 
   @zentol I checked the descroption, if I eliminate the use of hasTimeLeft() and switch to timeLeftIfAny() in bunch of cases it would lead to unnecessary evaluations. And If I use hasTimeLeft() so what time to wait instead timeLeftIfAny()?
   To counter this only I used both together, I thought intent is to prevent negative value from being passed, seems the intent is something else?
   
   *Apologies for checkstyles, I thought all Apache projects have same rules, so assumed it would go same here, which wasn't the case. :( 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services