[GitHub] [calcite] asolimando commented on a change in pull request #2710: [CALCITE-4997] Keep APPROX_COUNT_DISTINCT in some SqlDialects

[GitBox <gi...@apache.org>]

asolimando commented on a change in pull request #2710:
URL: https://github.com/apache/calcite/pull/2710#discussion_r803433468



##########
File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -6043,6 +6043,25 @@ private void checkLiteral2(String expression, String expected) {
     sql.ok(expected);
   }
 
+  @Test void testSelectApproxCountDistinct() {
+    final String query = "select approx_count_distinct(\"product_id\") from \"product\"";
+    final String expectedAccurate = "SELECT COUNT(DISTINCT \"product_id\")\n"

Review comment:
       Nitpick: not a native speaker here, but I think that the opposite of "approximate" is "exact" here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org