[GitHub] [jackrabbit-oak] anchela opened a new pull request #528: OAK-9737 : Avoid duplicate tree resolution by using ResultRow.getTree

[GitBox <gi...@apache.org>]

anchela opened a new pull request #528:
URL: https://github.com/apache/jackrabbit-oak/pull/528


   hi @thomasmueller , i would appreciate if you had time to review the proposed changes.
   
   in particular i would like to get your input on usage of 'seletorname' in ResultRowToAuthorizable. is it correct to use the first one in case the passed selectornames are not empty? i didn't try to understand if using a differen selector name would make a difference (in UserQueryManagerTest.testFindWithRelPathMultipleSelectorNames) and got the same tree back for all selectornames... but maybe that was a coincidence? how would i else know which selectorname to use?
   
   thanks for taking the time to review. much appreciated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jackrabbit-oak] anchela merged pull request #528: OAK-9737 : Avoid duplicate tree resolution by using ResultRow.getTree

[GitBox <gi...@apache.org>]

anchela merged pull request #528:
URL: https://github.com/apache/jackrabbit-oak/pull/528


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org