[GitHub] [incubator-superset] michellethomas commented on issue #6996: [Design Proposal] New Chart Creation flow

[GitBox <gi...@apache.org>]

michellethomas commented on issue #6996: [Design Proposal] New Chart Creation flow
URL: https://github.com/apache/incubator-superset/issues/6996#issuecomment-471640168
 
 
   Hi, thanks for creating this design proposal. I recently worked on the datasource control, and have a few comments about that section of the designs. We recently brought back the ability to change datasources from the explore view (https://github.com/apache/incubator-superset/pull/6816), it's been an important feature for users and one we'd like to keep around. We also tried to move away from using icons to avoid having a number of icons when there are lot of actions (I don't have a super strong opinion about this but just thought I'd note it).
   
   @xtinec also had a PR to bring back the + metadata button next to the datasource control (not sure if this is something they still need to keep https://github.com/apache/incubator-superset/pull/6911).
   
   We also have some pretty long table names, so something short like `def.fact_dags` fits into the space between "Select datasource" and the icons, but many of our datasource names are longer and showing more of the table name is important. I can get more specific about this if it's helpful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org