You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/08 15:48:11 UTC
[GitHub] [incubator-devlake] likyh opened a new issue, #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
likyh opened a new issue, #3330:
URL: https://github.com/apache/incubator-devlake/issues/3330
## What and why to refactor
https://github.com/apache/incubator-devlake/blob/7b0199a6d8557d4f18b73200d619a96d10df0163/config-ui/src/hooks/usePipelineValidation.jsx#L22-L45
<img width="610" alt="image" src="https://user-images.githubusercontent.com/3294100/194715800-b5b793cf-1267-4ea2-b480-4df88638efa3.png">
But it only uses little params and I don't think it will use `projectId/boardId/...` in validation in future.
## Describe the solution you'd like
Delete them.
Delete unnecessary params will help us read code with less burden. Here the burden means worry about where the vars are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet closed issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
mintsweet closed issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
URL: https://github.com/apache/incubator-devlake/issues/3330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3330:
URL: https://github.com/apache/incubator-devlake/issues/3330#issuecomment-1344932500
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
URL: https://github.com/apache/incubator-devlake/issues/3330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3330:
URL: https://github.com/apache/incubator-devlake/issues/3330#issuecomment-1334608453
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3330:
URL: https://github.com/apache/incubator-devlake/issues/3330#issuecomment-1282468095
This is fine to cleanup, A majority of the validation rules was removed from the Pipeline Validator and moved to Blueprint Validator as a consequence of v0.12.0 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] yumengwang03 commented on issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
yumengwang03 commented on issue #3330:
URL: https://github.com/apache/incubator-devlake/issues/3330#issuecomment-1346801030
@likyh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on issue #3330: [Refactor][config-ui] delete unused params in `usePipelineValidation.jsx`
Posted by GitBox <gi...@apache.org>.
mintsweet commented on issue #3330:
URL: https://github.com/apache/incubator-devlake/issues/3330#issuecomment-1372155189
**usePipelineValidation** has been deleted, so close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org