You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2013/04/04 22:04:15 UTC

[jira] [Updated] (SOLR-4672) requests for cores which had known startup init failures should result in 500 not 404

     [ https://issues.apache.org/jira/browse/SOLR-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-4672:
---------------------------

    Attachment: SOLR-4672.patch

patch that adds the neccessary logic to CoreContainer to throw 500 exception from getCore(name) if the name is in the list of core's with init failures.

I've updated CoreContainerCoreInitFailuresTest and done some manual testing with the example webapp to verify this works right.

the one thing i'm not 100% sure of is if this is behaving the way it should when dealing with lazy loaded transient cores. From what i can tell, this should already already work because of how lazy loaded cores are created on demand, but i'm not 100% certain that i understand what's happening in all cases here.  Either wya it would be good to have a test of this.

[~erickerickson]: if you could take a look and give me some guidance on how it should work, and how to write a good test for that it would be appreciated.
                
> requests for cores which had known startup init failures should result in 500 not 404
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-4672
>                 URL: https://issues.apache.org/jira/browse/SOLR-4672
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-4672.patch
>
>
> SOLR-3591 added support for tracking if a core failed to init properly, and reporting this data back in STATUS request to the CoreAdminHandler so they could be displayed in the UI.
> Attempts to use those cores anyway (for queries or updates, etc...) by users/clients that may not realize the core failed to init results in 404 errors because the core doesn't exist, however it should be fairly straight forward to intead return a 500 error wrapping the cause of the init failure.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org