You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2020/04/10 16:01:04 UTC

[hbase] branch master updated: HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format (#1479)

This is an automated email from the ASF dual-hosted git repository.

busbey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 09d20fb  HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format (#1479)
09d20fb is described below

commit 09d20fb4d7a5e7f791eafe63bd662a70759d08c7
Author: Sean Busbey <bu...@apache.org>
AuthorDate: Fri Apr 10 11:00:53 2020 -0500

    HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format (#1479)
    
    Signed-off-by: stack <st...@apache.org>
    Signed-off-by: Viraj Jasani <vj...@apache.org>
    Signed-off-by: Josh Elser <el...@apache.org>
---
 .../java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java    | 4 ++--
 .../java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
index 45b9d80..231ab09 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
@@ -435,7 +435,7 @@ public class DefaultMobStoreCompactor extends DefaultCompactor {
                     } else {
                       throw new IOException(String.format("MOB cell did not contain a tablename " +
                           "tag. should not be possible. see ref guide on mob troubleshooting. " +
-                          "store={} cell={}", getStoreInfo(), c));
+                          "store=%s cell=%s", getStoreInfo(), c));
                     }
                   }
                 }
@@ -491,7 +491,7 @@ public class DefaultMobStoreCompactor extends DefaultCompactor {
               } else {
                 throw new IOException(String.format("MOB cell did not contain a tablename " +
                     "tag. should not be possible. see ref guide on mob troubleshooting. " +
-                    "store={} cell={}", getStoreInfo(), c));
+                    "store=%s cell=%s", getStoreInfo(), c));
               }
             } else {
               String errMsg = String.format("Corrupted MOB reference: %s", c.toString());
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
index 0f8852f..b62a8e3 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
@@ -246,7 +246,7 @@ public class FaultyMobStoreCompactor extends DefaultMobStoreCompactor {
                 } else {
                   throw new IOException(String.format("MOB cell did not contain a tablename " +
                       "tag. should not be possible. see ref guide on mob troubleshooting. " +
-                      "store={} cell={}", getStoreInfo(), c));
+                      "store=%s cell=%s", getStoreInfo(), c));
                 }
               } else {
                 // If the value is not larger than the threshold, it's not regarded a mob. Retrieve
@@ -270,7 +270,7 @@ public class FaultyMobStoreCompactor extends DefaultMobStoreCompactor {
                   } else {
                     throw new IOException(String.format("MOB cell did not contain a tablename " +
                         "tag. should not be possible. see ref guide on mob troubleshooting. " +
-                        "store={} cell={}", getStoreInfo(), c));
+                        "store=%s cell=%s", getStoreInfo(), c));
                   }
                 }
               }