You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/06 01:46:51 UTC
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=h1) Report
> Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4772/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4772 +/- ##
==========================================
+ Coverage 72.59% 72.59% +<.01%
==========================================
Files 205 205
Lines 15401 15402 +1
Branches 1183 1183
==========================================
+ Hits 11180 11181 +1
Misses 4218 4218
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...cripts/dashboard/components/DashboardContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZENvbnRhaW5lci5qc3g=) | `0% <ø> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.5% <100%> (+0.01%)` | :arrow_up: |
| [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=footer). Last update [92230b8...b248744](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services