[GitHub] amansinha100 commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax

[GitBox <gi...@apache.org>]

amansinha100 commented on issue #1488: DRILL-786: Allow CROSS JOIN syntax
URL: https://github.com/apache/drill/pull/1488#issuecomment-437470894
 
 
   @ihuzenko sorry I missed responding to your earlier comment.  Based on your latest comment, I suppose we can merge this PR but explain the limitation of the Cross Join in the documentation until [DRILL-6839](https://issues.apache.org/jira/browse/DRILL-6839) is fixed.  
   
   Regarding the underlying issue with the 2 phase StreamingAgg, I did not quite understand the comment 
   > Currently for simple cross join query with aggregate function, physical rules are applied in order, which is wrong and results into PlanningException:
   
   This is not correct, since rules in Volcano planner are applied iteratively.  So there could be an initial state where a physical rule did not match but subsequently after other transformations, it could match and be triggered.  I would suggest enabling Calcite tracing to get a better idea of what's going on with the distribution traits of the NestedLoopJoin that is causing the downstream StreamingAgg to not get planned with multi-phase aggregation.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services