You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/31 01:11:13 UTC

[GitHub] [spark] sarutak opened a new pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

sarutak opened a new pull request #29314:
URL: https://github.com/apache/spark/pull/29314


   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This PR removes a test added in SPARK-32175(#29002).
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   That test is flaky. It can be mitigated by increasing the timeout but it would rather be simpler to remove the test.
   See also the [discussion](https://github.com/apache/spark/pull/29002#issuecomment-666746857).
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666866935


   LGTM, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] asfgit closed pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #29314:
URL: https://github.com/apache/spark/pull/29314


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666855992






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666854785


   cc: @tgravescs, @HyukjinKwon 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666855992






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666903491






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak edited a comment on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666856942


   This PR just removes existing test, so I'll merge this, not waiting for the CI result.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666870698


   Merged into `master` and `branch-3.0`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on pull request #29314: [FOLLOWUP][SPARK-32175] Remove flaky test added in SPARK-32175

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29314:
URL: https://github.com/apache/spark/pull/29314#issuecomment-666856942


   This PR just removes existing test, so I'll merge this, not waiting the CI result.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org