[GitHub] [flink] zentol commented on issue #10678: [FLINK-15355][plugin] Remove parent first from plugin classloader.

[GitBox <gi...@apache.org>]

zentol commented on issue #10678: [FLINK-15355][plugin] Remove parent first from plugin classloader.
URL: https://github.com/apache/flink/pull/10678#issuecomment-570217991
 
 
   Parent-first patterns still make sense for plugins for things like jdk classes, logging and similar, if anything to reduce the amount of loaded classes.
   
   The issue isn't even that we defer to the parent in some cases, but that hadoop of all things is in the default list.
   
   My feeling is that we should just introduce a separate pattern for plugins that doesn't include any library patterns. The existing patterns was added for usages in user-code in the first place; it seems reasonable that plugins would use a different one.
   This should be simple to add; we'd just have to modify PluginConfig to use a separate pattern instead.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services