[jira] [Commented] (ZOOKEEPER-2503) Inconsistency between myid documentation and implementation

["Patrick Hunt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410054#comment-15410054 ] 

Patrick Hunt commented on ZOOKEEPER-2503:
-----------------------------------------

I believe that the myid is used as part of the server id, in order to get a unique value for quorum formation. iirc it's the top 8 bits of the server id. Hence the reason why we mention that in the docs. afaik we never "enforced" this at the code level. On the plus side it would be a good idea, on the minus side it might break existing configurations....


> Inconsistency between myid documentation and implementation
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2503
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2503
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>             Fix For: 3.5.3, 3.4.10
>
>
> In ZK documentation, we have:
> "The myid file consists of a single line containing only the text of that machine's id. So myid of server 1 would contain the text "1" and nothing else. The id must be unique within the ensemble and should have a value between 1 and 255."
> This however is not enforced in code, which should be fixed either in documentation that we remove the restriction of the range 1-255 or in code we enforce such constraint.
> Discussion thread:
> http://zookeeper-user.578899.n2.nabble.com/Is-myid-actually-limited-to-1-255-td7581270.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)