You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 12:01:59 UTC
Review Request 70809: Fixed non-deferred callback calling
Master::send() in UpdateFramework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70809/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description
-------
Fixed non-deferred callback calling Master::send() in UpdateFramework.
Diffs
-----
src/master/master.cpp c41d912817a8e84dd3c97008dda76249fd197745
Diff: https://reviews.apache.org/r/70809/diff/1/
Testing
-------
make check + tests from https://reviews.apache.org/r/70755/ which is not committed yet:
`./bin/mesos-tests.sh --verbose --gtest_filter="UpdateFrameworkV0Test*" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko
Re: Review Request 70809: Fixed non-deferred callback calling
Master::send() in UpdateFramework.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70809/#review215746
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70809]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 7, 2019, 12:01 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70809/
> -----------------------------------------------------------
>
> (Updated June 7, 2019, 12:01 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed non-deferred callback calling Master::send() in UpdateFramework.
>
>
> Diffs
> -----
>
> src/master/master.cpp c41d912817a8e84dd3c97008dda76249fd197745
>
>
> Diff: https://reviews.apache.org/r/70809/diff/1/
>
>
> Testing
> -------
>
> make check + tests from https://reviews.apache.org/r/70755/ which is not committed yet:
>
> `./bin/mesos-tests.sh --verbose --gtest_filter="UpdateFrameworkV0Test*" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>