You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 12:11:27 UTC
[GitHub] [flink] zentol opened a new pull request #10812:
[FLINK-15523][conf] Japicmp checks ConfigConstants
zentol opened a new pull request #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812
Reverts the removal of several `@Public` fields and re-enables the japicmp checks for `ConfigConstants`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10812: [FLINK-15523][conf]
Japicmp checks ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812#issuecomment-572540515
<!--
Meta data
Hash:c7f9c8ba8d128fac30651631f042d0994d77439b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c7f9c8ba8d128fac30651631f042d0994d77439b
-->
## CI report:
* c7f9c8ba8d128fac30651631f042d0994d77439b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10812: [FLINK-15523][conf]
Japicmp checks ConfigConstants
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812#issuecomment-573082392
Looks good, thank you for fixing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10812:
[FLINK-15523][conf] Japicmp checks ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812#issuecomment-572540515
<!--
Meta data
Hash:c7f9c8ba8d128fac30651631f042d0994d77439b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143723316 TriggerType:PUSH TriggerID:c7f9c8ba8d128fac30651631f042d0994d77439b
Hash:c7f9c8ba8d128fac30651631f042d0994d77439b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4224 TriggerType:PUSH TriggerID:c7f9c8ba8d128fac30651631f042d0994d77439b
-->
## CI report:
* c7f9c8ba8d128fac30651631f042d0994d77439b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143723316) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4224)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10812:
[FLINK-15523][conf] Japicmp checks ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812#issuecomment-572540515
<!--
Meta data
Hash:c7f9c8ba8d128fac30651631f042d0994d77439b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143723316 TriggerType:PUSH TriggerID:c7f9c8ba8d128fac30651631f042d0994d77439b
Hash:c7f9c8ba8d128fac30651631f042d0994d77439b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4224 TriggerType:PUSH TriggerID:c7f9c8ba8d128fac30651631f042d0994d77439b
-->
## CI report:
* c7f9c8ba8d128fac30651631f042d0994d77439b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143723316) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4224)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10812: [FLINK-15523][conf]
Japicmp checks ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812#issuecomment-572536096
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c7f9c8ba8d128fac30651631f042d0994d77439b (Thu Jan 09 12:16:14 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10812: [FLINK-15523][conf]
Japicmp checks ConfigConstants
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10812: [FLINK-15523][conf] Japicmp checks ConfigConstants
URL: https://github.com/apache/flink/pull/10812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services