You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/13 15:01:21 UTC

[GitHub] [arrow] Shamazo opened a new pull request, #13154: [ARROW-16572] Fix LZ4 build for external projects

Shamazo opened a new pull request, #13154:
URL: https://github.com/apache/arrow/pull/13154

   The use of CMAKE_SOURCE_DIR is not compatible with projects that build arrow from source as a CMake project dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #13154: ARROW-16572: [C++] Fix LZ4 build for external projects

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13154:
URL: https://github.com/apache/arrow/pull/13154#issuecomment-1127167760

   Benchmark runs are scheduled for baseline = 85513fee694436c5ad082afa8a74d2c3e5d05209 and contender = 5c684c20748aa9b8fca9ccd1fa5375ebadb0ff20. 5c684c20748aa9b8fca9ccd1fa5375ebadb0ff20 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/95fdbf85f4cf47cfa62ec369011ebcba...126dce38245c416592a4915c2bfb40da/)
   [Finished :arrow_down:0.12% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fa4e08b057ab4cc5b7fb24cd40eab6f7...be7bc9de41064f57bf3a76f1ed234476/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6ea8148095c041cea04f8b3cba9c0e37...a66fd72614f444bbb82061a484d0cdac/)
   [Finished :arrow_down:0.12% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0b3bd6db3e9f4a64a3a668a901f12ee1...3bb4bb50bf154ca88441b9def8f1948a/)
   Buildkite builds:
   [Finished] [`5c684c20` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/764)
   [Finished] [`5c684c20` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/761)
   [Finished] [`5c684c20` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/751)
   [Finished] [`5c684c20` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/767)
   [Finished] [`85513fee` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/763)
   [Finished] [`85513fee` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/760)
   [Finished] [`85513fee` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/750)
   [Finished] [`85513fee` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/766)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou closed pull request #13154: ARROW-16572: [C++] Fix LZ4 build for external projects

Posted by GitBox <gi...@apache.org>.
kou closed pull request #13154: ARROW-16572: [C++] Fix LZ4 build for external projects
URL: https://github.com/apache/arrow/pull/13154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #13154: ARROW-16572; [C++] Fix LZ4 build for external projects

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13154:
URL: https://github.com/apache/arrow/pull/13154#issuecomment-1126657846

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #13154: ARROW-16572; [C++] Fix LZ4 build for external projects

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13154:
URL: https://github.com/apache/arrow/pull/13154#issuecomment-1126657840

   https://issues.apache.org/jira/browse/ARROW-16572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] Shamazo commented on pull request #13154: [ARROW-16572] Fix LZ4 build for external projects

Posted by GitBox <gi...@apache.org>.
Shamazo commented on PR #13154:
URL: https://github.com/apache/arrow/pull/13154#issuecomment-1126189630

   This broke GTest in the third party toolchain. I am new to the Arrow CMake, but looking through it, it is not clear to me how this impacts the GTest build. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org