You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "funky-eyes (via GitHub)" <gi...@apache.org> on 2024/01/25 14:10:48 UTC

[PR] optimize: server compatible io.seata package [incubator-seata]

funky-eyes opened a new pull request, #6310:
URL: https://github.com/apache/incubator-seata/pull/6310

   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have registered the PR [changes](../changes).
   
   ### Ⅰ. Describe what this PR did
   
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#issuecomment-1914267198

   > Is it more appropriate to put the deprecated classes in the "compatible" folder?
   
   This is the server-side class, not the client-side, and moving it into compatible will cause the server to rely on unnecessary classes unless a server-compatible is added.
   这是server侧的类，而不是client侧，如果移入compatible中会导致server依赖一些不必要的类，除非增加一个server-compatible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#discussion_r1469003316


##########
server/src/main/java/io/seata/server/cluster/raft/sync/msg/RaftSyncMessage.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.seata.server.cluster.raft.sync.msg;
+
+import static org.apache.seata.common.DefaultValues.DEFAULT_RAFT_COMPRESSOR;
+import static org.apache.seata.common.DefaultValues.DEFAULT_RAFT_SERIALIZATION;
+import static org.apache.seata.core.constants.ConfigurationKeys.SERVER_RAFT_COMPRESSOR;
+
+
+import org.apache.seata.common.util.StringUtils;
+import org.apache.seata.config.ConfigurationFactory;
+import org.apache.seata.core.compressor.CompressorType;
+import org.apache.seata.core.protocol.Version;
+import org.apache.seata.core.serializer.SerializerType;
+
+@Deprecated
+public class RaftSyncMessage implements java.io.Serializable {

Review Comment:
   This is an old class, but because the original class had its package name changed, it became a new class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#issuecomment-1911431697

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `2 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`7227cc1`)](https://app.codecov.io/gh/apache/incubator-seata/commit/7227cc142360385561b4d01c78a712488a120d42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 51.95% compared to head [(`377272f`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 30.18%.
   
   > :exclamation: Current head 377272f differs from pull request most recent head bfcb186. Consider uploading reports for the commit bfcb186 to get more accurate results
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6310/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##                2.x    #6310       +/-   ##
   =============================================
   - Coverage     51.95%   30.18%   -21.78%     
   - Complexity     5174     5464      +290     
   =============================================
     Files           918      933       +15     
     Lines         32039    60317    +28278     
     Branches       3866     7124     +3258     
   =============================================
   + Hits          16647    18206     +1559     
   - Misses        13767    40221    +26454     
   - Partials       1625     1890      +265     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/seata/common/DefaultValues.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vRGVmYXVsdFZhbHVlcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...che/seata/common/exception/JsonParseException.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vZXhjZXB0aW9uL0pzb25QYXJzZUV4Y2VwdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [.../org/apache/seata/common/metadata/ClusterRole.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vbWV0YWRhdGEvQ2x1c3RlclJvbGUuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/seata/common/metadata/Metadata.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vbWV0YWRhdGEvTWV0YWRhdGEuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...apache/seata/common/metadata/MetadataResponse.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vbWV0YWRhdGEvTWV0YWRhdGFSZXNwb25zZS5qYXZh) | `80.00% <ø> (ø)` | |
   | [...in/java/org/apache/seata/common/metadata/Node.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vbWV0YWRhdGEvTm9kZS5qYXZh) | `100.00% <ø> (ø)` | |
   | [...java/org/apache/seata/common/util/ConfigTools.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vdXRpbC9Db25maWdUb29scy5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ava/org/apache/seata/common/util/DurationUtil.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vdXRpbC9EdXJhdGlvblV0aWwuamF2YQ==) | `83.33% <ø> (ø)` | |
   | [...a/org/apache/seata/common/util/HttpClientUtil.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vdXRpbC9IdHRwQ2xpZW50VXRpbC5qYXZh) | `47.54% <ø> (ø)` | |
   | [...main/java/org/apache/seata/common/util/IOUtil.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb21tb24vdXRpbC9JT1V0aWwuamF2YQ==) | `70.00% <ø> (ø)` | |
   | ... and [108 more](https://app.codecov.io/gh/apache/incubator-seata/pull/6310?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [121 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6310/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#discussion_r1466436558


##########
changes/en-us/2.x.md:
##########
@@ -74,7 +74,10 @@ Add changes here for all PR submitted to the 2.x branch.
 - [[#6294](https://github.com/apache/incubator-seata/pull/6294)] split the frontend resource build process into separate profiles
 - [[#6297](https://github.com/apache/incubator-seata/pull/6297)] fix problem of `maven-pmd-plugin`
 - [[#6298](https://github.com/apache/incubator-seata/pull/6298)] repackage name to org.apache.seata
+<<<<<<< HEAD
+=======
 - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] disable Publish OSSRH workflow
+>>>>>>> 5412202ee622104c925b5e26c35193062e7f09a7

Review Comment:
   ```suggestion
   - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] disable Publish OSSRH workflow
   - [[#6310](https://github.com/apache/incubator-seata/pull/6310)] seata-server compatible io.seata package
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "ptyin (via GitHub)" <gi...@apache.org>.
ptyin commented on PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#issuecomment-1914273762

   > > Is it more appropriate to put the deprecated classes in the "compatible" folder?
   > 
   > This is the server-side class, not the client-side, and moving it into compatible will cause the server to rely on unnecessary classes unless a server-compatible is added. 这是server侧的类，而不是client侧，如果移入compatible中会导致server依赖一些不必要的类，除非增加一个server-compatible
   
   Uhhhh, my bad. I forgot this is the server module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#discussion_r1466435690


##########
changes/zh-cn/2.x.md:
##########
@@ -72,7 +72,10 @@
 - [[#6294](https://github.com/apache/incubator-seata/pull/6294)] 拆分前端资源打包流程到单独的profile
 - [[#6297](https://github.com/apache/incubator-seata/pull/6297)] 修复 `maven-pmd-plugin` 相关的问题
 - [[#6298](https://github.com/apache/incubator-seata/pull/6298)] 重命名包名为 org.apache.seata
+<<<<<<< HEAD
+=======
 - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] 禁用 OSSRH 发布工作流
+>>>>>>> 5412202ee622104c925b5e26c35193062e7f09a7

Review Comment:
   ```suggestion
   <<<<<<< HEAD
   - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] 禁用 OSSRH 发布工作流
   - [[#6310](https://github.com/apache/incubator-seata/pull/6310)] seata-server兼容io.seata包
   
   ```



##########
changes/en-us/2.x.md:
##########
@@ -74,7 +74,10 @@ Add changes here for all PR submitted to the 2.x branch.
 - [[#6294](https://github.com/apache/incubator-seata/pull/6294)] split the frontend resource build process into separate profiles
 - [[#6297](https://github.com/apache/incubator-seata/pull/6297)] fix problem of `maven-pmd-plugin`
 - [[#6298](https://github.com/apache/incubator-seata/pull/6298)] repackage name to org.apache.seata
+<<<<<<< HEAD
+=======
 - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] disable Publish OSSRH workflow
+>>>>>>> 5412202ee622104c925b5e26c35193062e7f09a7

Review Comment:
   ```suggestion
   <<<<<<< HEAD
   - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] disable Publish OSSRH workflow
   - [[#6310](https://github.com/apache/incubator-seata/pull/6310)] seata-server compatible io.seata package
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#discussion_r1466435690


##########
changes/zh-cn/2.x.md:
##########
@@ -72,7 +72,10 @@
 - [[#6294](https://github.com/apache/incubator-seata/pull/6294)] 拆分前端资源打包流程到单独的profile
 - [[#6297](https://github.com/apache/incubator-seata/pull/6297)] 修复 `maven-pmd-plugin` 相关的问题
 - [[#6298](https://github.com/apache/incubator-seata/pull/6298)] 重命名包名为 org.apache.seata
+<<<<<<< HEAD
+=======
 - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] 禁用 OSSRH 发布工作流
+>>>>>>> 5412202ee622104c925b5e26c35193062e7f09a7

Review Comment:
   ```suggestion
   - [[#6304](https://github.com/apache/incubator-seata/pull/6304)] 禁用 OSSRH 发布工作流
   - [[#6310](https://github.com/apache/incubator-seata/pull/6310)] seata-server兼容io.seata包
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org

Re: [PR] optimize: server compatible io.seata package [incubator-seata]

Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #6310:
URL: https://github.com/apache/incubator-seata/pull/6310#discussion_r1467240609


##########
server/src/main/java/io/seata/server/cluster/raft/sync/msg/RaftSyncMessage.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.seata.server.cluster.raft.sync.msg;
+
+import static org.apache.seata.common.DefaultValues.DEFAULT_RAFT_COMPRESSOR;
+import static org.apache.seata.common.DefaultValues.DEFAULT_RAFT_SERIALIZATION;
+import static org.apache.seata.core.constants.ConfigurationKeys.SERVER_RAFT_COMPRESSOR;
+
+
+import org.apache.seata.common.util.StringUtils;
+import org.apache.seata.config.ConfigurationFactory;
+import org.apache.seata.core.compressor.CompressorType;
+import org.apache.seata.core.protocol.Version;
+import org.apache.seata.core.serializer.SerializerType;
+
+@Deprecated
+public class RaftSyncMessage implements java.io.Serializable {

Review Comment:
   it's a new  class but deprecate ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org