You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/23 04:42:04 UTC

[GitHub] [shardingsphere] tristaZero commented on pull request #5760: Optimized aes encryption implementation

tristaZero commented on pull request #5760:
URL: https://github.com/apache/shardingsphere/pull/5760#issuecomment-632984252


   Hi @klbokkl, thanks for your first contribution to ShardingSphere community, welcome! :)
   I reviewed your PR, and it looks great to avoid initializing encryptor repeatedly. However, like @yu199195 said, checking style is required, since your code is public to anyone all over the world.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org