You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Marcus Rueckert <da...@web.de> on 2005/05/07 17:31:46 UTC
inconsistency in handling of commandline parameters
hi,
since 1.2 svn skips unversioned items if you run "svn up *"
this rocks imho. but "svn proplist *" breaks on unversioned items.
can we get this consistent through all commands for 1.2?
darix
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Allow 'svn proplist' to skip unversioned items (was: Re: inconsistency in handling of commandline parameters)
Posted by kf...@collab.net.
"S.Ramaswamy" <ra...@collab.net> writes:
> > On 2005-05-08 07:56:02 -0700, S.Ramaswamy wrote:
> >> Allow 'svn proplist' to skip unversioned files and continue.
> >>
> >> * subversion/clients/cmdline/proplist-cmd.c
> >> (svn_cl__proplist) : Test for SVN_ERR_UNVERSIONED_RESOURCE and
> >> continue
> >> with a warning if so.
> >
> > cool. :)
> >
> > what other commands should behave the same way?
> >
> > maybe: commit, blame,...?
> >
> > i think any command that can handle multiple items at the commandline
> > should use this logic?
> >
> > comments?
>
> Actually for issue #2030, Karl made a macro SVN_CL__TRY or somesuch that
> could be used if the only error to be skipped is
> SVN_ERR_UNVERSIONED_RESOURCE. Since for proplist, there is more than one
> one condition to be skipped I didn't use it.
In r14883, I took SVN_CL__TRY() and extended it for proplist.
SVN_CL__TRY() was only being used in two other places, and in both of
them it made sense to skip SVN_ERR_ENTRY_NOT_FOUND anyway.
Also, now propdel and propset can pay attention to opt_state->quiet
when skipping, which they should have been doing all along. See
r14883 for details.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Allow 'svn proplist' to skip unversioned items (was: Re: inconsistency in handling of commandline parameters)
Posted by "S.Ramaswamy" <ra...@collab.net>.
> On 2005-05-08 07:56:02 -0700, S.Ramaswamy wrote:
>> Allow 'svn proplist' to skip unversioned files and continue.
>>
>> * subversion/clients/cmdline/proplist-cmd.c
>> (svn_cl__proplist) : Test for SVN_ERR_UNVERSIONED_RESOURCE and
>> continue
>> with a warning if so.
>
> cool. :)
>
> what other commands should behave the same way?
>
> maybe: commit, blame,...?
>
> i think any command that can handle multiple items at the commandline
> should use this logic?
>
> comments?
Actually for issue #2030, Karl made a macro SVN_CL__TRY or somesuch that
could be used if the only error to be skipped is
SVN_ERR_UNVERSIONED_RESOURCE. Since for proplist, there is more than one
one condition to be skipped I didn't use it.
Not sure how many other commands need this fix.
>
> darix
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Allow 'svn proplist' to skip unversioned items (was: Re: inconsistency in handling of commandline parameters)
Posted by Marcus Rueckert <da...@web.de>.
On 2005-05-08 07:56:02 -0700, S.Ramaswamy wrote:
> Allow 'svn proplist' to skip unversioned files and continue.
>
> * subversion/clients/cmdline/proplist-cmd.c
> (svn_cl__proplist) : Test for SVN_ERR_UNVERSIONED_RESOURCE and continue
> with a warning if so.
cool. :)
what other commands should behave the same way?
maybe: commit, blame,...?
i think any command that can handle multiple items at the commandline
should use this logic?
comments?
darix
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Allow 'svn proplist' to skip unversioned items (was: Re: inconsistency in handling of commandline parameters)
Posted by "S.Ramaswamy" <ra...@collab.net>.
ChangeLog:
Allow 'svn proplist' to skip unversioned files and continue.
* subversion/clients/cmdline/proplist-cmd.c
(svn_cl__proplist) : Test for SVN_ERR_UNVERSIONED_RESOURCE and continue
with a warning if so.
Re: inconsistency in handling of commandline parameters
Posted by Branko Čibej <br...@xbc.nu>.
Marcus Rueckert wrote:
>hi,
>
>since 1.2 svn skips unversioned items if you run "svn up *"
>this rocks imho. but "svn proplist *" breaks on unversioned items.
>
>can we get this consistent through all commands for 1.2?
>
>
Only if you write the patches and push them through the vote in the next
48 hours.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org