[jira] [Commented] (MINIFICPP-315) Allow Properties to support plain 'b' suffix

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258238#comment-16258238 ] 

ASF GitHub Bot commented on MINIFICPP-315:
------------------------------------------

GitHub user dtrodrigues opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/196

    MINIFICPP-315 - allow plain b suffix on properties

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-315

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #196
    
----
commit 5e18e4f42112bd65aaecf65cb6c1434182addb87
Author: Dustin Rodrigues <du...@gmail.com>
Date:   2017-11-18T22:04:25Z

    MINIFICPP-315 - allow plain b suffix on properties

----


> Allow Properties to support plain 'b' suffix
> --------------------------------------------
>
>                 Key: MINIFICPP-315
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-315
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Dustin Rodrigues
>            Priority: Minor
>
> Currently, if a property is 'x kb', the value is multiplied by 1024 but if it's 'x k', it's multiplied by 1000. However, values are of the form 'x b' or 'x B', the value doesn't get parsed at all. Instead, 'x' should be returned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)